Harden code execution with fail-closed confinement#41
Open
Mzack9999 wants to merge 4 commits into
Open
Conversation
Add a fail-closed confine package (bubblewrap, Seatbelt, hardened Docker) and route Eval/EvalWithVirtualEnv through it. Remove the superseded sandbox package and its examples.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the old
sandboxpackage with a newconfinepackage. Confinement is deny-by-default and fails closed: if it is requested but no backend is available, execution is refused instead of running on the host.Backends:
Source is injected as bytes instead of a shell heredoc, and container logs are demuxed with stdcopy.
EvalandEvalWithVirtualEnvroute through the confiner. Enable viaOptions.SandboxorOptions.Confinement.Breaking changes:
sandboxpackage and its examplesVirtualEnvTypeenumEvalWithVirtualEnvnow takes a*confine.Policyinstead of aVirtualEnvType+*sandbox.DockerConfigurationnuclei's code protocol needs a matching update before bumping gozero.
Tests cover the argv/profile/container-config builders, env scrubbing, fail-closed selection, and live isolation (skipped when the native backend is absent).