Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable rspec monkeypatching #3407

Merged
merged 1 commit into from
Jan 29, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion spec/controllers/application_controller_spec.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# frozen_string_literal: true

describe ApplicationController, type: :controller do
RSpec.describe ApplicationController, type: :controller do
routes { Spotlight::Engine.routes }
let(:exhibit) { FactoryBot.create(:exhibit) }

Expand Down
2 changes: 1 addition & 1 deletion spec/controllers/spotlight/about_pages_controller_spec.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# frozen_string_literal: true

describe Spotlight::AboutPagesController, type: :controller, versioning: true do
RSpec.describe Spotlight::AboutPagesController, type: :controller, versioning: true do
routes { Spotlight::Engine.routes }
let(:valid_attributes) { { 'title' => 'MyString', thumbnail: { iiif_url: '' } } }

Expand Down
2 changes: 1 addition & 1 deletion spec/controllers/spotlight/appearances_controller_spec.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# frozen_string_literal: true

describe Spotlight::AppearancesController, type: :controller do
RSpec.describe Spotlight::AppearancesController, type: :controller do
routes { Spotlight::Engine.routes }
let(:exhibit) { FactoryBot.create(:exhibit) }

Expand Down
2 changes: 1 addition & 1 deletion spec/controllers/spotlight/application_controller_spec.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# frozen_string_literal: true

describe Spotlight::ApplicationController, type: :controller do
RSpec.describe Spotlight::ApplicationController, type: :controller do
routes { Spotlight::Engine.routes }
let(:exhibit) { FactoryBot.create(:exhibit) }

Expand Down
2 changes: 1 addition & 1 deletion spec/controllers/spotlight/attachments_controller_spec.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# frozen_string_literal: true

describe Spotlight::AttachmentsController, type: :controller do
RSpec.describe Spotlight::AttachmentsController, type: :controller do
routes { Spotlight::Engine.routes }
let(:exhibit) { FactoryBot.create(:exhibit) }

Expand Down
2 changes: 1 addition & 1 deletion spec/controllers/spotlight/browse_controller_spec.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# frozen_string_literal: true

describe Spotlight::BrowseController, type: :controller do
RSpec.describe Spotlight::BrowseController, type: :controller do
routes { Spotlight::Engine.routes }
let(:exhibit) { FactoryBot.create(:exhibit) }
let!(:search) { FactoryBot.create(:published_search, exhibit:) }
Expand Down
2 changes: 1 addition & 1 deletion spec/controllers/spotlight/bulk_actions_controller_spec.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# frozen_string_literal: true

describe Spotlight::BulkActionsController, type: :controller do
RSpec.describe Spotlight::BulkActionsController, type: :controller do
routes { Spotlight::Engine.routes }
let(:exhibit) { FactoryBot.create(:skinny_exhibit) }

Expand Down
2 changes: 1 addition & 1 deletion spec/controllers/spotlight/bulk_updates_controller_spec.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# frozen_string_literal: true

describe Spotlight::BulkUpdatesController, type: :controller do
RSpec.describe Spotlight::BulkUpdatesController, type: :controller do
routes { Spotlight::Engine.routes }
let(:exhibit) { FactoryBot.create(:exhibit) }

Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# frozen_string_literal: true

describe Spotlight::ConfirmationsController, type: :controller do
RSpec.describe Spotlight::ConfirmationsController, type: :controller do
routes { Spotlight::Engine.routes }
before do
# rubocop:disable RSpec/InstanceVariable
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# frozen_string_literal: true

describe Spotlight::ContactEmailController, type: :controller do
RSpec.describe Spotlight::ContactEmailController, type: :controller do
routes { Spotlight::Engine.routes }
let(:contact_email) { FactoryBot.create(:contact_email) }

Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# frozen_string_literal: true

describe Spotlight::ContactFormsController, type: :controller do
RSpec.describe Spotlight::ContactFormsController, type: :controller do
routes { Spotlight::Engine.routes }
let(:exhibit) { FactoryBot.create(:exhibit) }
let(:honeypot_field_name) { Spotlight::Engine.config.spambot_honeypot_email_field }
Expand Down
2 changes: 1 addition & 1 deletion spec/controllers/spotlight/contacts_controller_spec.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# frozen_string_literal: true

describe Spotlight::ContactsController, type: :controller do
RSpec.describe Spotlight::ContactsController, type: :controller do
routes { Spotlight::Engine.routes }
describe 'when not logged in' do
describe 'GET edit' do
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# frozen_string_literal: true

describe Spotlight::CustomFieldsController, type: :controller do
RSpec.describe Spotlight::CustomFieldsController, type: :controller do
routes { Spotlight::Engine.routes }
let(:exhibit) { FactoryBot.create(:exhibit) }

Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# frozen_string_literal: true

describe Spotlight::CustomSearchFieldsController, type: :controller do
RSpec.describe Spotlight::CustomSearchFieldsController, type: :controller do
routes { Spotlight::Engine.routes }
let(:exhibit) { FactoryBot.create(:exhibit) }

Expand Down
2 changes: 1 addition & 1 deletion spec/controllers/spotlight/dashboards_controller_spec.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# frozen_string_literal: true

describe Spotlight::DashboardsController, type: :controller do
RSpec.describe Spotlight::DashboardsController, type: :controller do
routes { Spotlight::Engine.routes }
let(:exhibit) { FactoryBot.create(:exhibit) }
let(:repository) { double }
Expand Down
2 changes: 1 addition & 1 deletion spec/controllers/spotlight/exhibits_controller_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

require 'rack/test'

describe Spotlight::ExhibitsController, type: :controller do
RSpec.describe Spotlight::ExhibitsController, type: :controller do
routes { Spotlight::Engine.routes }
let(:exhibit) { FactoryBot.create(:exhibit) }

Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# frozen_string_literal: true

describe Spotlight::FeaturePagesController, type: :controller, versioning: true do
RSpec.describe Spotlight::FeaturePagesController, type: :controller, versioning: true do
routes { Spotlight::Engine.routes }

let(:valid_attributes) { { 'title' => 'MyString', thumbnail_attributes: { iiif_url: '' } } }
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# frozen_string_literal: true

describe Spotlight::FeaturedImagesController, type: :controller do
RSpec.describe Spotlight::FeaturedImagesController, type: :controller do
routes { Spotlight::Engine.routes }

describe 'when the user is not authorized' do
Expand Down
2 changes: 1 addition & 1 deletion spec/controllers/spotlight/filters_controller_spec.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# frozen_string_literal: true

describe Spotlight::FiltersController do
RSpec.describe Spotlight::FiltersController do
routes { Spotlight::Engine.routes }

describe '#create' do
Expand Down
2 changes: 1 addition & 1 deletion spec/controllers/spotlight/groups_controller_spec.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# frozen_string_literal: true

describe Spotlight::GroupsController, type: :controller do
RSpec.describe Spotlight::GroupsController, type: :controller do
routes { Spotlight::Engine.routes }
let(:exhibit) { FactoryBot.create(:exhibit) }
let!(:group) { FactoryBot.create(:group, exhibit:) }
Expand Down
2 changes: 1 addition & 1 deletion spec/controllers/spotlight/home_pages_controller_spec.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# frozen_string_literal: true

describe Spotlight::HomePagesController, type: :controller, versioning: true do
RSpec.describe Spotlight::HomePagesController, type: :controller, versioning: true do
routes { Spotlight::Engine.routes }
let(:valid_attributes) { { 'title' => 'MyString', thumbnail: { iiif_url: '' } } }
let(:exhibit) { FactoryBot.create(:exhibit) }
Expand Down
2 changes: 1 addition & 1 deletion spec/controllers/spotlight/job_trackers_controller_spec.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# frozen_string_literal: true

describe Spotlight::JobTrackersController, type: :controller do
RSpec.describe Spotlight::JobTrackersController, type: :controller do
routes { Spotlight::Engine.routes }
let(:job_tracker) { FactoryBot.create(:job_tracker, on: exhibit) }
let(:exhibit) { FactoryBot.create(:exhibit) }
Expand Down
2 changes: 1 addition & 1 deletion spec/controllers/spotlight/languages_controller_spec.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# frozen_string_literal: true

describe Spotlight::LanguagesController do
RSpec.describe Spotlight::LanguagesController do
routes { Spotlight::Engine.routes }

describe '#create' do
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# frozen_string_literal: true

describe Spotlight::MetadataConfigurationsController, type: :controller do
RSpec.describe Spotlight::MetadataConfigurationsController, type: :controller do
routes { Spotlight::Engine.routes }
let(:exhibit) { FactoryBot.create(:exhibit) }

Expand Down
2 changes: 1 addition & 1 deletion spec/controllers/spotlight/pages_controller_spec.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# frozen_string_literal: true

describe Spotlight::PagesController, type: :controller do
RSpec.describe Spotlight::PagesController, type: :controller do
routes { Spotlight::Engine.routes }
let(:exhibit) { FactoryBot.create(:exhibit) }
let(:feature_page) { FactoryBot.create(:feature_page, exhibit:, published: false) }
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# frozen_string_literal: true

describe Spotlight::Resources::CsvUploadController, type: :controller do
RSpec.describe Spotlight::Resources::CsvUploadController, type: :controller do
routes { Spotlight::Engine.routes }
let(:exhibit) { FactoryBot.create(:exhibit) }

Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# frozen_string_literal: true

describe Spotlight::Resources::UploadController, type: :controller do
RSpec.describe Spotlight::Resources::UploadController, type: :controller do
routes { Spotlight::Engine.routes }
let(:exhibit) { FactoryBot.create(:exhibit) }

Expand Down
2 changes: 1 addition & 1 deletion spec/controllers/spotlight/resources_controller_spec.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# frozen_string_literal: true

describe Spotlight::ResourcesController, type: :controller do
RSpec.describe Spotlight::ResourcesController, type: :controller do
routes { Spotlight::Engine.routes }
let(:exhibit) { FactoryBot.create(:exhibit) }

Expand Down
2 changes: 1 addition & 1 deletion spec/controllers/spotlight/roles_controller_spec.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# frozen_string_literal: true

describe Spotlight::RolesController, type: :controller do
RSpec.describe Spotlight::RolesController, type: :controller do
routes { Spotlight::Engine.routes }
let(:exhibit) { FactoryBot.create(:exhibit) }

Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# frozen_string_literal: true

describe Spotlight::SearchConfigurationsController, type: :controller do
RSpec.describe Spotlight::SearchConfigurationsController, type: :controller do
routes { Spotlight::Engine.routes }
let(:exhibit) { FactoryBot.create(:exhibit) }

Expand Down
2 changes: 1 addition & 1 deletion spec/controllers/spotlight/searches_controller_spec.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# frozen_string_literal: true

describe Spotlight::SearchesController, type: :controller do
RSpec.describe Spotlight::SearchesController, type: :controller do
routes { Spotlight::Engine.routes }
let(:exhibit) { FactoryBot.create(:exhibit) }

Expand Down
2 changes: 1 addition & 1 deletion spec/controllers/spotlight/sites_controller_spec.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# frozen_string_literal: true

describe Spotlight::SitesController, type: :controller do
RSpec.describe Spotlight::SitesController, type: :controller do
routes { Spotlight::Engine.routes }

describe 'when user does not have access' do
Expand Down
2 changes: 1 addition & 1 deletion spec/controllers/spotlight/solr_controller_spec.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# frozen_string_literal: true

describe Spotlight::SolrController, type: :controller do
RSpec.describe Spotlight::SolrController, type: :controller do
routes { Spotlight::Engine.routes }
let(:exhibit) { FactoryBot.create(:exhibit) }

Expand Down
2 changes: 1 addition & 1 deletion spec/controllers/spotlight/tags_controller_spec.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# frozen_string_literal: true

describe Spotlight::TagsController, type: :controller do
RSpec.describe Spotlight::TagsController, type: :controller do
include ActiveJob::TestHelper

routes { Spotlight::Engine.routes }
Expand Down
2 changes: 1 addition & 1 deletion spec/controllers/spotlight/translations_controller_spec.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# frozen_string_literal: true

describe Spotlight::TranslationsController do
RSpec.describe Spotlight::TranslationsController do
routes { Spotlight::Engine.routes }
let(:exhibit) { FactoryBot.create(:exhibit) }

Expand Down
2 changes: 1 addition & 1 deletion spec/controllers/spotlight/versions_controller_spec.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# frozen_string_literal: true

describe Spotlight::VersionsController, type: :controller, versioning: true do
RSpec.describe Spotlight::VersionsController, type: :controller, versioning: true do
routes { Spotlight::Engine.routes }

describe 'when not logged in' do
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# frozen_string_literal: true

describe Spotlight::ViewConfigurationsController, type: :controller do
RSpec.describe Spotlight::ViewConfigurationsController, type: :controller do
routes { Spotlight::Engine.routes }
let(:exhibit) { FactoryBot.create(:exhibit) }

Expand Down
2 changes: 1 addition & 1 deletion spec/features/about_page_spec.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# frozen_string_literal: true

describe 'About page', type: :feature, versioning: true do
RSpec.describe 'About page', type: :feature, versioning: true do
let(:exhibit) { FactoryBot.create(:exhibit) }
let(:exhibit_curator) { FactoryBot.create(:exhibit_curator, exhibit:) }
let!(:about_page1) { FactoryBot.create(:about_page, title: 'First Page', exhibit:) }
Expand Down
2 changes: 1 addition & 1 deletion spec/features/add_contacts_spec.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# frozen_string_literal: true

describe 'Add a contact to an exhibit', type: :feature do
RSpec.describe 'Add a contact to an exhibit', type: :feature do
let(:curator) { FactoryBot.create(:exhibit_curator, exhibit:) }
let(:exhibit) { FactoryBot.create(:exhibit) }
let!(:about_page) { FactoryBot.create(:about_page, exhibit:) }
Expand Down
2 changes: 1 addition & 1 deletion spec/features/add_custom_field_metadata_spec.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# frozen_string_literal: true

describe 'Adding custom metadata field data', type: :feature do
RSpec.describe 'Adding custom metadata field data', type: :feature do
let(:exhibit) { FactoryBot.create(:exhibit) }
let(:admin) { FactoryBot.create(:exhibit_admin, exhibit:) }
let(:custom_field) { FactoryBot.create(:custom_field, exhibit:) }
Expand Down
2 changes: 1 addition & 1 deletion spec/features/add_iiif_manifest_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

require 'spec_helper'

describe 'adding IIIF Manifest', type: :feature do
RSpec.describe 'adding IIIF Manifest', type: :feature do
let(:exhibit) { FactoryBot.create(:exhibit) }
let(:curator) { FactoryBot.create(:exhibit_curator, exhibit:) }

Expand Down
2 changes: 1 addition & 1 deletion spec/features/add_items_spec.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# frozen_string_literal: true

describe 'Uploading a non-repository item', type: :feature do
RSpec.describe 'Uploading a non-repository item', type: :feature do
include ActiveJob::TestHelper

let!(:exhibit) { FactoryBot.create(:exhibit) }
Expand Down
2 changes: 1 addition & 1 deletion spec/features/alt_text_dashboard_spec.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# frozen_string_literal: true

describe 'Alt text dashboard', type: :feature do
RSpec.describe 'Alt text dashboard', type: :feature do
let(:exhibit) { FactoryBot.create(:exhibit) }
let(:curator) { FactoryBot.create(:exhibit_curator, exhibit:) }

Expand Down
2 changes: 1 addition & 1 deletion spec/features/browse_category_spec.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# frozen_string_literal: true

describe 'Browse pages' do
RSpec.describe 'Browse pages' do
let(:exhibit) { FactoryBot.create(:exhibit) }

context 'a browse page' do
Expand Down
2 changes: 1 addition & 1 deletion spec/features/confirm_email_spec.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# frozen_string_literal: true

describe 'Confirming an email', type: :feature do
RSpec.describe 'Confirming an email', type: :feature do
let(:exhibit) { FactoryBot.create(:exhibit) }
let(:contact_email) { Spotlight::ContactEmail.create!(email: '[email protected]', exhibit:) }
let(:raw_token) { contact_email.instance_variable_get(:@raw_confirmation_token) }
Expand Down
2 changes: 1 addition & 1 deletion spec/features/create_exhibit_spec.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# frozen_string_literal: true

describe 'Create a new exhibit', type: :feature do
RSpec.describe 'Create a new exhibit', type: :feature do
let(:user) { FactoryBot.create(:site_admin) }

before do
Expand Down
2 changes: 1 addition & 1 deletion spec/features/create_page_spec.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# frozen_string_literal: true

describe 'Creating a page', type: :feature do
RSpec.describe 'Creating a page', type: :feature do
let(:exhibit) { FactoryBot.create(:exhibit) }
let(:exhibit_curator) { FactoryBot.create(:exhibit_curator, exhibit:) }

Expand Down
2 changes: 1 addition & 1 deletion spec/features/dashboard_spec.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# frozen_string_literal: true

describe 'Dashboard', type: :feature do
RSpec.describe 'Dashboard', type: :feature do
let(:exhibit) { FactoryBot.create(:exhibit) }
let!(:parent_feature_page) do
FactoryBot.create(:feature_page, title: 'Parent Page', exhibit:)
Expand Down
2 changes: 1 addition & 1 deletion spec/features/edit_contact_spec.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# frozen_string_literal: true

describe 'Add a contact to an exhibit', type: :feature do
RSpec.describe 'Add a contact to an exhibit', type: :feature do
let(:curator) { FactoryBot.create(:exhibit_curator, exhibit:) }
let(:exhibit) { FactoryBot.create(:exhibit) }
let!(:about_page) { FactoryBot.create(:about_page, exhibit:) }
Expand Down
Loading
Loading