Add config for updated gems #3402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taylor-steve
force-pushed
the
osd-oembed-sprockets
branch
from
e385689 to
1aa53ef
Compare
jcoyne
reviewed
Jan 14, 2025
|
We should decide on sul-dlss/openseadragon-rails#17 first. |
corylown
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the v4 installer to work with the newest openseadragon/blacklight-oembed gems.
Currently I think it's best to leave all the sprockets config work out of the OSD gem. If Spotlight v4 still cares about sprockets we can make it do the work, especially since Spotlight v4 is a bit of a special case, deleting
app/javascript/application.js.