Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump wait time for autocomplete specs #3323

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions spec/features/autocomplete_typeahead_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,9 @@

describe 'IIIF Integration' do
context 'for items that include a IIIF manifest' do
it 'instantiates a cropper and persists all levels of the IIIF manifest' do
it 'instantiates a cropper and persists all levels of the IIIF manifest', default_max_wait_time: 20 do
skip('Passes locally, but too flaky in CI') if ENV['CI']

visit spotlight.edit_exhibit_appearance_path(exhibit)
click_link 'Exhibit masthead'

Expand All @@ -21,7 +23,6 @@
expect(page).to have_css('.leaflet-container', visible: true)

click_button 'Save changes'
sleep 1 # Test fails without this after move to Propshaft.

featured_image = Spotlight::FeaturedImage.last

Expand All @@ -32,15 +33,16 @@
expect(featured_image.iiif_tilesource).to eq 'https://stacks.stanford.edu/image/iiif/gk446cj2442/gk446cj2442_05_0001/info.json'
end

it 'instantiates the multi-image selector when an multi-image item is chosen in the typeahead (and again on edit)' do
it 'instantiates the multi-image selector when an multi-image item is chosen in the typeahead (and again on edit)', default_max_wait_time: 20 do
skip('Passes locally, but too flaky in CI') if ENV['CI']

allow(Spotlight::Engine.config).to receive(:exhibit_themes).and_return(['default'])

visit spotlight.edit_exhibit_appearance_path(exhibit)

check 'Show background image in masthead'

fill_in_typeahead_field(with: 'xd327cm9378', type: 'featured-image')
sleep 1 # HACK: that seems to mysteriously work.

expect(page).to have_css('[data-panel-image-pagination]', text: /Image 1 of 2/, visible: true)

Expand Down
2 changes: 1 addition & 1 deletion spec/features/javascript/edit_in_place_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@
end
end

it 'updates the metadata label' do
it 'updates the metadata label', default_max_wait_time: 20 do
visit spotlight.exhibit_dashboard_path(exhibit)

within '#sidebar' do
Expand Down
Loading