Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A better slideshow start thumb fit #52

Merged
merged 3 commits into from
May 2, 2018
Merged

A better slideshow start thumb fit #52

merged 3 commits into from
May 2, 2018

Conversation

mejackreed
Copy link
Contributor

Fixes #50

Before

screen shot 2018-05-02 at 3 10 54 pm

After

screen shot 2018-05-02 at 3 11 05 pm

Merge #46 first (first two commits are there)

@mejackreed
Copy link
Contributor Author

One question here is, object-fit is not compatible with IE. Should we add a polyfill here, or just call it out for adopters to manually add?

@mejackreed mejackreed changed the title A better slideshow start thumb fit [WIP] A better slideshow start thumb fit May 2, 2018
@mejackreed mejackreed changed the title [WIP] A better slideshow start thumb fit A better slideshow start thumb fit May 2, 2018
@mejackreed
Copy link
Contributor Author

I've decided to punt on IE compatibility for the following reasons:

  • its hard to test this (Microsoft cloud browser testing doesn't allow IE testing for free anymore)
  • its unsupported by Microsoft
  • without the polyfill really doesn't look too bad.

@aeschylus aeschylus merged commit 93880f3 into master May 2, 2018
@mejackreed mejackreed deleted the object-fit branch May 2, 2018 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mejackreed @aeschylus @jcoyne