logout feature #432

TigerInYourDream · 2025-03-11T15:26:22Z

Based on PR #293, I found an error message during logout:
2024-12-24T07:58:55.514036Z ERROR matrix_sdk_ui::sync_service: Error while processing encryption in sync service: Something wrong happened in sliding sync: the server returned an error: [401 / M_UNKNOWN_TOKEN] Invalid access token passed.
Root cause:
The error is related to SYNC_SERVICE handling during logout process.

Changes:

Updated SYNC_SERVICE handling during logout
Tested the fix with Google SSO login/logout flow

Signed-off-by: Alvin <[email protected]>

kevinaboos · 2025-03-11T20:13:27Z

Thanks Alvin. I'm a bit confused -- is this a replacement for #293, or something that should be merged in after #293 as an addition to it?

Also, is it ready for review or shall I wait for something else?

TigerInYourDream · 2025-03-12T04:28:26Z

Thanks Alvin. I'm a bit confused -- is this a replacement for #293, or something that should be merged in after #293 as an addition to it?

Also, is it ready for review or shall I wait for something else?

Due to the age of PR #293 and substantial changes in the codebase, resolving merge conflicts became quite challenging. I've contacted the original author, Guocork, who also suggested creating a new PR. Therefore, I've created a fresh PR implementing the same functionality with updated code and comprehensive testing. Could you please review this new implementation?

Signed-off-by: Alvin <[email protected]>

kevinaboos

Thanks Alvin, great start on this feature!

I left some comments below. In general, make sure to name things carefully --- try to give variables and types very specific names that cannot be misinterpreted. (I know naming is hard, so it'll take some time to get that right. No worries.)

src/home/spaces_dock.rs

src/login/login_screen.rs

src/sliding_sync.rs

TigerInYourDream · 2025-03-13T04:35:10Z

Thanks Alvin, great start on this feature!

I left some comments below. In general, make sure to name things carefully --- try to give variables and types very specific names that cannot be misinterpreted. (I know naming is hard, so it'll take some time to get that right. No worries.)

Thank you for the review. I will try to improve the naming conventions and continue working on it.

Signed-off-by: Alvin <[email protected]>

alanpoon · 2025-03-18T07:59:03Z

Suggest adding a modal for logout confirmation
Perhaps delete the "latest_user_id.txt" in the app data directory
After logout, restarting the app will see a prompt saying fail to "Could not restore previous user session"

Signed-off-by: Alvin <[email protected]>

TigerInYourDream · 2025-03-18T13:35:07Z

Suggest adding a modal for logout confirmation

Perhaps delete the "latest_user_id.txt" in the app data directory

After logout, restarting the app will see a prompt saying fail to "Could not restore previous user session"

Thanks for the review.

Signed-off-by: Alvin <[email protected]>

src/home/spaces_dock.rs

src/login/login_screen.rs

Signed-off-by: Alvin <[email protected]>

src/persistent_state.rs

alanpoon · 2025-04-30T13:37:04Z

src/app.rs

+                    }
+                }
+            }
+
            if let Some(LoginAction::LoginSuccess) = action.downcast_ref() {
                log!("Received LoginAction::LoginSuccess, hiding login view.");
                self.app_state.logged_in = true;


need to call cx.action(RoomsPanelAction::DockLoad); To restore User's previous Dock state, as you cx.action(RoomsPanelAction::DockLoad) when login out.

alanpoon · 2025-04-30T13:38:26Z

src/home/spaces_dock.rs

+                WidgetUid(0), 
+                &Scope::empty().path,


use either self.widget_uid().
use scope.path when there is scope.

alanpoon · 2025-04-30T13:41:19Z

src/login/logout_confirm_modal.rs

+
+
+impl LogoutConfirmModalRef {
+    /// See [`LogoutConfirmModal::set_message()`].


For document linking, LogoutConfirmModal::set_message needs to be public function.

alanpoon · 2025-05-02T07:30:08Z

It is might better using Tokio's shutdown background to close all asynchronous task.
I have asked AI about it and I have asked vaguely tried it. It looks promising and have lesser code changes.
b.txt
Perhaps timeout with arbitrary duration can be removed.

Cargo.toml

src/home/spaces_dock.rs

Guocork · 2025-05-08T02:34:40Z

src/app.rs

+
+    pub fn show_logout_confirm_modal(&self, cx: &mut Cx) {
+        let modal = self.ui.modal(id!(logout_confirm_modal));
+        modal.open(cx);
+    }
+
+    pub fn hide_logout_confirm_modal(&self, cx: &mut Cx) {
+        let modal = self.ui.modal(id!(logout_confirm_modal));
+        log!("Got modal reference for hiding: {:?}", modal);
+        modal.close(cx);
+    }
+


This is just a simple wrapper around the modal's open and hide methods. I feel like we can just call self.ui.modal(id!(logout_confirm_modal)).open() or hide() directly, without adding extra wrappers.

src/login/logout_confirm_modal.rs

Guocork · 2025-05-08T02:43:00Z

I once implemented a modal for Moly: https://github.com/moxin-org/moly/pull/341/files.
There is a very simple modal in Moly: https://github.com/moxin-org/moly/blob/main/src/shared/modal.rs
you can check out both of these for reference.

TigerInYourDream · 2025-05-17T03:15:15Z

It is might better using Tokio's shutdown background to close all asynchronous task. I have asked AI about it and I have asked vaguely tried it. It looks promising and have lesser code changes. b.txt Perhaps timeout with arbitrary duration can be removed.

I opted against using both shutdown_background and shutdown_timeout because they immediately begin closing the Tokio runtime, which causes subsequent async tasks to fail. Our logout flow still requires the runtime for critical operations like cleaning up state and sending notifications after the core tasks are aborted. I tested both shutdown methods and they proved problematic, resulting in incomplete logout processes where the application wouldn't properly transition to the login state.

alanpoon · 2025-05-20T11:16:32Z

It is might better using Tokio's shutdown background to close all asynchronous task. I have asked AI about it and I have asked vaguely tried it. It looks promising and have lesser code changes. b.txt Perhaps timeout with arbitrary duration can be removed.

I opted against using both shutdown_background and shutdown_timeout because they immediately begin closing the Tokio runtime, which causes subsequent async tasks to fail. Our logout flow still requires the runtime for critical operations like cleaning up state and sending notifications after the core tasks are aborted. I tested both shutdown methods and they proved problematic, resulting in incomplete logout processes where the application wouldn't properly transition to the login state.

I don't see what issue there is https://github.com/alanpoon/robrix/tree/fix-logout-shutdown. The issue is that your "logout_successful = true" is inside successful response of client.matrix_auth().logout() which is not necessary. If the access token is invalid -> client.matrix_auth().logout() will fail. But access token is invalid is also logged out state.

Signed-off-by: Alvin <[email protected]>

kevinaboos · 2025-05-29T20:44:50Z

I noticed that my review has been requested here and that this has been marked as waiting-on-review. However, there's also another PR #494 that seems to supersede this.

Can you guys clarify the relationship between these PRs and which one I should be looking at?

TigerInYourDream · 2025-05-30T03:29:30Z

Regarding PR494, I had a discussion with @alanpoon about which method to use for terminating asynchronous tasks in Tokio. After our discussion, we concluded that using shutdown_background would make this PR more concise and efficient.

As a result, I have updated the original code to implement the shutdown_background version. This change simplifies the task termination process while maintaining the desired functionality.

I kindly request a review of the current PR to ensure that the implementation aligns with our project standards and effectively addresses the task termination requirements.

Your feedback on this updated approach would be greatly appreciated. Please let me know if you need any further information or clarification on the changes made.

Thank you for your time and consideration. @kevinaboos

kevinaboos · 2025-05-30T17:03:17Z

Ok, that adds a bit of detail, but doesn't fully answer my question. Is #494 being closed? Is this being merged in and then #494 afterwards? @alanpoon's previous comments seem to indicate that the approach hasn't been settled on.

fix pr project-robius#293 about logout

27871c3

Signed-off-by: Alvin <[email protected]>

TigerInYourDream and others added 2 commits March 12, 2025 12:34

Merge branch 'main' into fix-logout

708d493

explain key exchange

c380f0f

Signed-off-by: Alvin <[email protected]>

kevinaboos requested changes Mar 12, 2025

View reviewed changes

kevinaboos added the waiting-on-author This issue is waiting on the original author for a response label Mar 12, 2025

TigerInYourDream marked this pull request as draft March 13, 2025 04:50

TigerInYourDream and others added 4 commits March 15, 2025 01:28

CORE_TASKS for save and abort async task

9b0a7fd

Signed-off-by: Alvin <[email protected]>

refactor logout

b4242ed

Signed-off-by: Alvin <[email protected]>

Merge branch 'main' into fix-logout

82704ed

fix: typos

1b827fa

Signed-off-by: Alvin <[email protected]>

TigerInYourDream marked this pull request as ready for review March 18, 2025 07:24

trace more long term async task and resource async_task

66e00ea

Signed-off-by: Alvin <[email protected]>

TigerInYourDream and others added 4 commits March 19, 2025 01:50

Merge branch 'main' into fix-logout

d702758

Merge branch 'main' into fix-logout

0d3d156

Merge branch 'main' into fix-logout

ccfc991

fix with clippy check

53dc860

Signed-off-by: Alvin <[email protected]>

TigerInYourDream requested review from kevinaboos and Guocork March 20, 2025 16:40

TigerInYourDream changed the title ~~fix pr #293 about logout~~ logout feature Mar 21, 2025

Guocork reviewed Mar 23, 2025

View reviewed changes

src/home/spaces_dock.rs Outdated Show resolved Hide resolved

Guocork reviewed Mar 23, 2025

View reviewed changes

src/login/login_screen.rs Outdated Show resolved Hide resolved

feat(auth): Enhance Matrix logout robustness and error handling

734536b

Signed-off-by: Alvin <[email protected]>

TigerInYourDream force-pushed the fix-logout branch from 273f1f1 to 734536b Compare March 24, 2025 05:14

feat(auth): delete_last_user_id file

f41d554

Signed-off-by: Alvin <[email protected]>

alanpoon reviewed Apr 18, 2025

View reviewed changes

src/persistent_state.rs Show resolved Hide resolved

Simplified logging in logout process

e98ff8c

alanpoon reviewed Apr 30, 2025

View reviewed changes

alanpoon closed this May 2, 2025

alanpoon reopened this May 2, 2025

TigerInYourDream and others added 2 commits May 7, 2025 10:14

improve code

43794bf

Merge branch 'main' into fix-logout

7232052

tyreseluo reviewed May 7, 2025

View reviewed changes

Cargo.toml Outdated Show resolved Hide resolved

Fix compilation issues after merging main into fix-logout

82542c6

Guocork reviewed May 8, 2025

View reviewed changes

src/home/spaces_dock.rs Outdated Show resolved Hide resolved

Guocork reviewed May 8, 2025

View reviewed changes

TigerInYourDream added 2 commits May 13, 2025 00:11

improve code use action not weight_action

5875399

close and open

bb29667

alanpoon mentioned this pull request May 26, 2025

Logout feature with tokio shutdown_background #494

Open

TigerInYourDream added 3 commits May 29, 2025 11:02

use shoutdown background

88d3011

Signed-off-by: Alvin <[email protected]>

Merge branch 'main' into fix-logout

827577d

clean code

ae6ef31

Signed-off-by: Alvin <[email protected]>

aaravlu added waiting-on-review This issue is waiting to be reviewed and removed waiting-on-author This issue is waiting on the original author for a response labels May 29, 2025

kevinaboos added waiting-on-author This issue is waiting on the original author for a response and removed waiting-on-review This issue is waiting to be reviewed labels May 29, 2025



		impl LogoutConfirmModalRef {
		/// See [`LogoutConfirmModal::set_message()`].

logout feature #432

Are you sure you want to change the base?

logout feature #432

Uh oh!

Conversation

TigerInYourDream commented Mar 11, 2025

Uh oh!

kevinaboos commented Mar 11, 2025

Uh oh!

TigerInYourDream commented Mar 12, 2025

Uh oh!

kevinaboos left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TigerInYourDream commented Mar 13, 2025

Uh oh!

alanpoon commented Mar 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TigerInYourDream commented Mar 18, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alanpoon Apr 30, 2025

Choose a reason for hiding this comment

Uh oh!

alanpoon Apr 30, 2025

Choose a reason for hiding this comment

Uh oh!

alanpoon Apr 30, 2025

Choose a reason for hiding this comment

Uh oh!

alanpoon commented May 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Guocork May 8, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Guocork commented May 8, 2025

Uh oh!

TigerInYourDream commented May 17, 2025

Uh oh!

alanpoon commented May 20, 2025

Uh oh!

kevinaboos commented May 29, 2025

Uh oh!

TigerInYourDream commented May 30, 2025

Uh oh!

kevinaboos commented May 30, 2025

Uh oh!

Uh oh!

alanpoon commented Mar 18, 2025 •

edited

Loading

alanpoon commented May 2, 2025 •

edited

Loading