Skip to content

Display audio messages. #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 37 commits into
base: main
Choose a base branch
from
Open

Display audio messages. #396

wants to merge 37 commits into from

Conversation

aaravlu
Copy link
Contributor

@aaravlu aaravlu commented Feb 17, 2025

Fixes #120
fix audio of issue120 Display multimedia messages: audio, video, stickers (gifs)

Fatal bug currently
All the audios use a global duration progress.

Fixed

@aaravlu aaravlu changed the title Display multimedia messages: audio, video, stickers (gifs) Display audio messages. Feb 21, 2025
@alanpoon
Copy link
Contributor

I can hear the audio and press the play and pause button on macOS.

@aaravlu
Copy link
Contributor Author

aaravlu commented Feb 26, 2025

I can hear the audio and press the play and pause button on macOS.

Thanks for test!

@aaravlu aaravlu requested a review from Copilot April 9, 2025 02:05
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

src/shared/audio_message_interface.rs:3707

  • The branch for handling MediaSource::Encrypted is empty, which may lead to unhandled cases for encrypted audio. Please implement the necessary handling or add a clarifying comment explaining why it is intentionally left empty.
        MediaSource::Encrypted(_e) => {

@aaravlu aaravlu marked this pull request as ready for review April 9, 2025 08:00
@aaravlu aaravlu requested a review from Copilot April 9, 2025 08:01
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

src/audio/audio_controller.rs:183

  • The magic number '44' is used as the default audio offset; consider defining it as a named constant to improve code readability and maintainability.
*self.selected.lock().unwrap() = Selected::Playing(*new_uid, 44);

@aaravlu aaravlu requested a review from Copilot April 9, 2025 08:06
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

src/audio/audio_controller.rs:183

  • [nitpick] The magic number '44' is used as the initial/reset audio position; consider defining it as a named constant to clarify its purpose and improve maintainability.
Selected::Playing(*new_uid, 44);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display multimedia messages: audio, video, stickers (gifs)
2 participants