Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SBOMER-81): Add license information to components #1163

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dwalluck
Copy link
Contributor

@dwalluck dwalluck commented Mar 4, 2025

If given an AnalyzedArtifact, add any SPDX license identifers to the licenses of the component. Only licenses for which an SPDX license identifier assertion could be made are listed here.

Since URLs are not unique per identifier, do not add any URL to the licenses of the component. Add any valid absolute URLs to the external references of the component.

Add the full list of licenses, including any licenses which have an SPDX license identifier of NOASSERTION or NONE to the license evidence of the component. The evidence licenses include URL and source information.

@dwalluck
Copy link
Contributor Author

dwalluck commented Mar 4, 2025

It looks like SbomUtils was changed a lot unless you use "Hide whitespace" option.

I inverted some if statements which reduces the indentation level and I think improves readability.

But, something cleaned up the import of constants. I didn't do that manually.

If given an `AnalyzedArtifact`, add any SPDX license identifers to the
licenses of the component. Only licenses for which an SPDX license
identifier assertion could be made are listed here.

Since URLs are not unique per identifier, do not add any URL to the
licenses of the component. Add any valid absolute URLs to the external
references of the component.

Add the full list of licenses, including any licenses which have an
SPDX license identifier of `NOASSERTION` or `NONE` to the license
evidence of the component. The evidence licenses include URL and
source information.
@dwalluck dwalluck changed the title SBOMER-81: Add license information to components feat(SBOMER-81): Add license information to components Mar 4, 2025
Copy link
Collaborator

@vibe13 vibe13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dwalluck this looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants