Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SBOMER-341): add select and search bar for manifests page #1156

Merged
merged 1 commit into from
Mar 12, 2025

Conversation

thavlice
Copy link
Contributor

@thavlice thavlice commented Mar 3, 2025

I am adding menu and search feature to Manifests page.

This planned to be implemented in the Requests page, but with more filters (there is just one additional in Manifests page).

Notes:

  • The options of the select (aka 'No filter' and 'Purl') are represented by string, but probably could be represented by enum/type, which could enable us to add more options easily
  • Currently, when no filter is applied, the request string contains query= with following value of (nothing), but this the same effect as not having the query= at all.

@thavlice thavlice requested a review from goldmann March 3, 2025 10:36
@thavlice thavlice force-pushed the searchbar-manifests-page branch from e36dbf6 to c253757 Compare March 7, 2025 14:18
@thavlice
Copy link
Contributor Author

thavlice commented Mar 7, 2025

The issues mentioned in the notes previously were fixed.

  • No filter now does not add query= to the request
  • The Select options are represented by enum type.

@thavlice thavlice marked this pull request as ready for review March 7, 2025 14:45
@goldmann goldmann merged commit 74ce45c into project-ncl:main Mar 12, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants