Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: Fix some more sonar issues with service #1134

Merged
merged 2 commits into from
Mar 12, 2025
Merged

style: Fix some more sonar issues with service #1134

merged 2 commits into from
Mar 12, 2025

Conversation

dwalluck
Copy link
Contributor

@dwalluck dwalluck commented Feb 7, 2025

No description provided.

@dwalluck dwalluck marked this pull request as draft February 7, 2025 23:07
@dwalluck dwalluck force-pushed the sonar-service branch 7 times, most recently from 2a76d47 to 70ab6b1 Compare February 10, 2025 15:51
@dwalluck dwalluck force-pushed the sonar-service branch 8 times, most recently from 8a407ae to 5664883 Compare February 11, 2025 17:41
@dwalluck dwalluck marked this pull request as ready for review February 11, 2025 17:59
@dwalluck dwalluck force-pushed the sonar-service branch 5 times, most recently from dca1a72 to f72aa88 Compare February 19, 2025 15:37
@goldmann goldmann self-requested a review February 20, 2025 10:44
goldmann
goldmann reviewed Feb 21, 2025
View reviewed changes
Copy link
Contributor

@goldmann goldmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at the PR and it looks good, thanks! I just want confirmation from @vibe13 that the equals method implementation is what we would expect it to be. Afterwards we can merge it.

@vibe13
Copy link
Collaborator

vibe13 commented Mar 10, 2025

@goldmann @dwalluck Apologies I missed the fact that this PR was pending my final confirmation. Yes equals and hashcode methods look good now, we can finally merge this one! Thanks all!

@vibe13 vibe13 merged commit 8b7e02d into project-ncl:main Mar 12, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janinko janinko janinko left review comments

@vibe13 vibe13 vibe13 approved these changes

@goldmann goldmann goldmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dwalluck @vibe13 @goldmann @janinko