Fix: Additional E2E tests for skinny image manifest type #1103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add additional E2E tests for "skinny" manifest images, additionally this type of image manifest failed at the inspect step but now fails in generation step, `org.jbo.sbo.cli.fea.sbo.adj.SyftImageAdjuster` where a version label is expected. Previous tests like madrel still manage to pass in tekton
goldmann
requested changes
Jan 29, 2025
There was a problem hiding this comment.
@jonathanchristison Can you please format commit messages according to https://www.conventionalcommits.org/en/v1.0.0/?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an additional two images to check with E2E tests, the test input json is now an array as opposed to multiple payloads in separate files.
This test would of originally failing due to alternative image manifest types (non-fat manifest) not being handled by the tekton inspect tasks, this simply tests for regression.
What I'm not sure on
@ParameterizedTest? The only advantage I can think of is if we find something similar in future and a list of images is easier