Skip to content

NCL-9179 Add support for MVN_RPM build type #651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 29, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"graphology-layout": "^0.6.1",
"graphology-layout-forceatlas2": "^0.10.1",
"lodash-es": "^4.17.21",
"pnc-api-types-ts": "project-ncl/pnc-api-types-ts#v3.1.3-SNAPSHOT-pnc-c84e958d9",
"pnc-api-types-ts": "project-ncl/pnc-api-types-ts#v3.2.5-SNAPSHOT-pnc-a4d831a85",
"react": "^18.3.1",
"react-dom": "^18.3.1",
"react-router": "7.6.3",
Expand Down
2 changes: 1 addition & 1 deletion src/common/buildConfigEntityAttributes.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { Build, BuildConfiguration } from 'pnc-api-types-ts';

import { TEntityAttributes } from 'common/entityAttributes';

const buildTypeValues: BuildConfiguration['buildType'][] = ['MVN', 'NPM', 'GRADLE', 'SBT'];
const buildTypeValues: BuildConfiguration['buildType'][] = ['MVN', 'NPM', 'GRADLE', 'SBT', 'MVN_RPM'];

interface IExtendedBuildConfig extends BuildConfiguration {
buildStatus: Build['status'];
Expand Down
4 changes: 4 additions & 0 deletions src/common/buildTypeData.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,4 +26,8 @@ export const buildTypeData: TBuildTypeData = {
id: 'SBT',
title: 'Scala Build Tool (SBT)',
},
MVN_RPM: {
id: 'MVN_RPM',
title: 'Maven RPM',
},
} as const;
1 change: 1 addition & 0 deletions src/common/colorMap.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ export const buildTypeColorMap: Record<string, LabelConfig> = {
NPM: { text: 'NPM', color: 'purple', hexColor: '#CBC1FF' }, // purple-100
GRADLE: { text: 'GRADLE', color: 'cyan', hexColor: '#A2D9D9' }, // cyan-100
SBT: { text: 'SBT', color: 'grey', hexColor: '#D2D2D2' }, // black-300
MVN_RPM: { text: 'MVN_RPM', color: 'orange', hexColor: '#F4B678' }, // orange-100
};

export const artifactQualityColorMap: Record<string, LabelConfig> = {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ const generateAlignmentParametersDescription = (buildType: BuildConfiguration['b
}

const cliProject =
buildType === buildTypeData.MVN.id
buildType === buildTypeData.MVN.id || buildType === buildTypeData.MVN_RPM.id
? { name: 'PME', url: 'https://release-engineering.github.io/pom-manipulation-ext/#feature-guide' }
: buildType === buildTypeData.GRADLE.id
? { name: 'GME', url: 'https://project-ncl.github.io/gradle-manipulator/#feature-guide' }
Expand Down Expand Up @@ -607,6 +607,15 @@ export const BuildConfigCreateEditPage = ({ isEditPage = false }: IBuildConfigCr
isRequired
label={buildConfigEntityAttributes.buildType.title}
fieldId={buildConfigEntityAttributes.buildType.id}
labelIcon={
<TooltipWrapper
tooltip={
<>
To view more information about {buildTypeData.MVN_RPM.title}, select an {buildTypeData.MVN_RPM.id} option.
</>
}
/>
}
>
<Select
id={buildConfigEntityAttributes.buildType.id}
Expand All @@ -620,6 +629,17 @@ export const BuildConfigCreateEditPage = ({ isEditPage = false }: IBuildConfigCr
))}
</Select>
<FormInputHelperText variant="error">{getFieldErrors(buildConfigEntityAttributes.buildType.id)}</FormInputHelperText>
<FormInputHelperText variant="default">
{getFieldValue(buildConfigEntityAttributes.buildType.id) === buildTypeData.MVN_RPM.id ? (
<>
The {buildTypeData.MVN_RPM.title} build is executing the alignment phase using PME and running Maven within the
builder pod. For more detail on the build phase, please refer to the{' '}
<a href="https://project-ncl.github.io/rpm-builder-maven-plugin/" target="_blank" rel="noopener noreferrer">
RPM Builder Maven Plugin documentation <ExternalLinkAltIcon />
</a>
</>
) : null}
</FormInputHelperText>
</FormGroup>

<FormGroup
Expand Down
2 changes: 1 addition & 1 deletion src/utils/formValidationHelpers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ const buildScriptChecker = (
export const validateBuildScript = (fieldValues: IFieldValues, options?: IBuildScriptCheckerOptions): boolean => {
return (
!fieldValues.buildScript ||
fieldValues.buildType !== buildTypeData.MVN.id ||
(fieldValues.buildType !== buildTypeData.MVN.id && fieldValues.buildType !== buildTypeData.MVN_RPM.id) ||
buildScriptChecker(fieldValues.buildScript, options)
);
};
Expand Down