[NCl-9058] Build Push and Milestone close #641
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DnsZhou
reviewed
Jun 10, 2025
DnsZhou
reviewed
Jun 10, 2025
There was a problem hiding this comment.
Verified on my local dev env with BC: TC30-temporary-push, brew-push list component and details page looks all good and no error or warning related to this change.
The new "Close Milestone" modal looks good, and I was able to close a milestone with Skip Brew push enabled, but I can't close it without Skip Brew push option. Not sure if it is due to dev env endpoint issue? @patrikk0123 do you have any idea on that?
|
I also tried to rebase NCL-9126 PR(https://github.com/project-ncl/pnc-web-ui-react/pull/638/files) on this code base, everything looks good as well. |
DnsZhou
previously approved these changes
Jun 10, 2025
|
@DnsZhou End date will be set only after all brew pushes have finished successfully |
patrikk0123
force-pushed
the
ncl9058
branch
3 times, most recently
from
5d5ed2a to
0f40af2
Compare
matedo1
previously approved these changes
Jun 10, 2025
…ers and attributes
matedo1
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.