Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NCL-8237] Support milestone-less Analysis in UI #627

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

[NCL-8237] Support milestone-less Analysis in UI #627

wants to merge 7 commits into from

Conversation

patrikk0123
Copy link
Contributor

No description provided.

@patrikk0123 patrikk0123 mentioned this pull request Mar 4, 2025
Closed
@patrikk0123 patrikk0123 requested a review from matedo1 March 4, 2025 16:19
matedo1
matedo1 previously approved these changes Mar 5, 2025
View reviewed changes
Copy link
Collaborator

@matedo1 matedo1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DnsZhou can you please test this PR on your local machine before it's merged?

@matedo1 matedo1 requested a review from DnsZhou March 5, 2025 08:46
@patrikk0123
Copy link
Contributor Author

also labels and their management (coming from report) need to be added in another jira

@matedo1
Copy link
Collaborator

matedo1 commented Mar 5, 2025

There are two additional jiras: NCL-8075, NCL-8076, can you update them or create a new jira if necessary?

@patrikk0123
Copy link
Contributor Author

patrikk0123 commented Mar 5, 2025 •
edited
Loading

NCL-8075 is about label management.
To display them should be simple enough to do it as part of this Jira, maybe.

@patrikk0123 patrikk0123 force-pushed the ncl8237 branch 2 times, most recently from 46ea137 to 2f6b2b7 Compare March 5, 2025 16:54
DnsZhou
DnsZhou previously approved these changes Mar 6, 2025
View reviewed changes
Copy link
Contributor

@DnsZhou DnsZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm on my local machine with dev env, deliverable-analyses list page with all filters, deliverable-analyses details page works all good. change of code is fine to me as well.

@matedo1 matedo1 self-requested a review March 6, 2025 07:55
matedo1
matedo1 requested changes Mar 6, 2025
View reviewed changes
Copy link
Collaborator

@matedo1 matedo1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @patrikk0123 , I did also some testing, please see Jira comment.

@patrikk0123 patrikk0123 force-pushed the ncl8237 branch 2 times, most recently from dfc4e69 to 39ae55e Compare March 11, 2025 15:50
@patrikk0123 patrikk0123 requested a review from matedo1 March 11, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DnsZhou DnsZhou DnsZhou left review comments

@matedo1 matedo1 Awaiting requested review from matedo1

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@patrikk0123 @matedo1 @DnsZhou