Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NCL-6996] Upgrade React to v18 #626

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[NCL-6996] Upgrade React to v18 #626

wants to merge 2 commits into from

Conversation

DnsZhou
Copy link
Contributor

@DnsZhou DnsZhou commented Feb 25, 2025

  • Updated React to version 18.3.1 and updated related dependencies.
  • Updated index.tsx and useServiceContainer.ts according to the new code changes.
  • Updated the test cases to comply with React V18 requirements.

@DnsZhou DnsZhou requested a review from matedo1 February 25, 2025 14:00
matedo1
matedo1 requested changes Feb 25, 2025
View reviewed changes
@DnsZhou DnsZhou force-pushed the ncl6996-upgradeReact18 branch from 2705283 to 62858d9 Compare February 25, 2025 14:51
@DnsZhou DnsZhou requested a review from matedo1 February 25, 2025 14:53
matedo1
matedo1 previously approved these changes Feb 26, 2025
View reviewed changes
Copy link
Collaborator

@matedo1 matedo1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait with merging until you confirm it's fully tested (see Jira for more information).

@DnsZhou DnsZhou force-pushed the ncl6996-upgradeReact18 branch 3 times, most recently from e508626 to 6d43385 Compare March 5, 2025 04:00
@matedo1
Copy link
Collaborator

matedo1 commented Mar 5, 2025

Hi @patrikk0123 , this PR is reaching its final version, could you please briefly test it too?

@matedo1 matedo1 requested a review from patrikk0123 March 5, 2025 09:00
@DnsZhou DnsZhou force-pushed the ncl6996-upgradeReact18 branch from 6d43385 to be5fb4f Compare March 6, 2025 04:09
@DnsZhou DnsZhou requested a review from matedo1 March 6, 2025 04:13
patrikk0123
patrikk0123 reviewed Mar 11, 2025
View reviewed changes
@DnsZhou DnsZhou force-pushed the ncl6996-upgradeReact18 branch from be5fb4f to 62db205 Compare March 11, 2025 14:10
@DnsZhou DnsZhou requested a review from patrikk0123 March 11, 2025 14:11
patrikk0123
patrikk0123 approved these changes Mar 11, 2025
View reviewed changes
Copy link
Contributor

@patrikk0123 patrikk0123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the code looks good, but didn't test it locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrikk0123 patrikk0123 patrikk0123 approved these changes

@matedo1 matedo1 Awaiting requested review from matedo1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DnsZhou @matedo1 @patrikk0123