Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NCL-9004 Update Orch to support PNC builds via Dingrogu (client code) #76

Conversation

tecarter94
Copy link
Contributor

Client code for initial implementation of Dingrogu build process using PNC build backend.

https://issues.redhat.com/browse/NCL-9004

@tecarter94 tecarter94 requested a review from thescouser89 March 7, 2025 12:28
Copy link
Collaborator

@thescouser89 thescouser89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just please remove the KonfluxAdapter so that it compiles. I believe the KonfluxAdapter is looking for the KonfluxBuildDriver and failing because of the rename.

@tecarter94 tecarter94 force-pushed the NCL-9004-Update-Orch-to-support-PNC-builds-via-Dingrogu-client-code branch from ee573cc to 4e57808 Compare March 10, 2025 02:32
@tecarter94
Copy link
Contributor Author

@thescouser89 Simpler solution in the end was to comment out portions of KonfluxAdapter that needed KonfluxBuildDriver. 🙂

@tecarter94 tecarter94 marked this pull request as ready for review March 10, 2025 02:37
@tecarter94 tecarter94 merged commit aab474e into project-ncl:main Mar 10, 2025
1 check passed
@thescouser89
Copy link
Collaborator

yayy awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants