[NCL-7742] Add brew push process #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jomrazek
force-pushed
the
push-process
branch
2 times, most recently
from
dff3e1b to
725676b
Compare
thescouser89
requested changes
Feb 28, 2025
There was a problem hiding this comment.
Woah I love seeing that PR because it shows that the structure is OKish and you understood it and it's not my worst spaghetti code! :)
Let me know if there's anything in that code organization that you'd like changed, what was confusing, and what can be improved!
I just found some tiny issues, and then we can just run it on Devel and test further! :)
...apter/src/main/java/org/jboss/pnc/dingrogu/restadapter/adapter/CausewayBuildPushAdapter.java
Outdated
Show resolved
Hide resolved
rest-workflow/src/main/java/org/jboss/pnc/dingrogu/restworkflow/workflows/BrewPushWorkflow.java
Show resolved
Hide resolved
...ter/src/main/java/org/jboss/pnc/dingrogu/restadapter/adapter/OrchBuildPushResultAdapter.java
Show resolved
Hide resolved
jomrazek
force-pushed
the
push-process
branch
3 times, most recently
from
c2da9e3 to
b6472ca
Compare
|
LGTM! THanks so much for the PR! <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.