Encoding performance #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elvisci
reviewed
Apr 13, 2017
src/otters_conn_zipkin.erl
Outdated
| -define(T_i16, 6). | ||
| -define(T_i32, 8). | ||
| -define(T_i64, 10). | ||
| -define(T_string, 11). |
There was a problem hiding this comment.
Invalid macro name T_string on line 34. Use UPPER_CASE.
elvisci
reviewed
Apr 13, 2017
src/otters_conn_zipkin.erl
Outdated
| @@ -28,6 +28,13 @@ | |||
| -compile(export_all). | |||
| -include("otters.hrl"). | |||
|
|
|||
| -define(T_i16, 6). | |||
There was a problem hiding this comment.
Invalid macro name T_i16 on line 31. Use UPPER_CASE.
elvisci
reviewed
Apr 13, 2017
src/otters_conn_zipkin.erl
Outdated
| @@ -28,6 +28,13 @@ | |||
| -compile(export_all). | |||
| -include("otters.hrl"). | |||
|
|
|||
| -define(T_i16, 6). | |||
| -define(T_i32, 8). | |||
| -define(T_i64, 10). | |||
There was a problem hiding this comment.
Invalid macro name T_i64 on line 33. Use UPPER_CASE.
elvisci
reviewed
Apr 13, 2017
src/otters_conn_zipkin.erl
Outdated
| @@ -28,6 +28,13 @@ | |||
| -compile(export_all). | |||
| -include("otters.hrl"). | |||
|
|
|||
| -define(T_i16, 6). | |||
| -define(T_i32, 8). | |||
There was a problem hiding this comment.
Invalid macro name T_i32 on line 32. Use UPPER_CASE.
elvisci
reviewed
Apr 13, 2017
src/otters_conn_zipkin.erl
Outdated
| -define(T_i64, 10). | ||
| -define(T_string, 11). | ||
| -define(T_struct, 12). | ||
| -define(T_list, 15). |
There was a problem hiding this comment.
Invalid macro name T_list on line 36. Use UPPER_CASE.
elvisci
reviewed
Apr 13, 2017
src/otters_conn_zipkin.erl
Outdated
| -define(T_i32, 8). | ||
| -define(T_i64, 10). | ||
| -define(T_string, 11). | ||
| -define(T_struct, 12). |
There was a problem hiding this comment.
Invalid macro name T_struct on line 35. Use UPPER_CASE.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite encoding to use binary building. ~40x performance boost for package encoding!