Skip to content

task(RHOAIENG-26481): Existing cluster RayJob demo notebook #875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: ray-jobs-feature
Choose a base branch
from

Conversation

chipspeak
Copy link
Contributor

Issue link

Jira

What changes have been made

New demo notebook which demonstrates the new RayJob submission against existing RayClusters.

Verification steps

  1. Build a version of the CodeFlare SDK from this branch.
  2. pip install this whl file in a local jupyter notebook.
  3. Run oc login using your OpenShift creds.
  4. Run through the notebook one cell at a time and verify via OpenShift pods etc

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 1, 2025
Copy link
Contributor

openshift-ci bot commented Aug 1, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kryanbeane for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chipspeak chipspeak marked this pull request as ready for review August 1, 2025 14:03
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 1, 2025
Copy link

codecov bot commented Aug 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.06%. Comparing base (e2fc98b) to head (138d7e0).

Additional details and impacted files
@@                Coverage Diff                @@
##           ray-jobs-feature     #875   +/-   ##
=================================================
  Coverage             93.06%   93.06%           
=================================================
  Files                    28       28           
  Lines                  1513     1513           
=================================================
  Hits                   1408     1408           
  Misses                  105      105           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant