Skip to content

build(deps-dev): bump @playwright/test from 1.49.0 to 1.53.1 in /ui-tests #846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
+15 −15
Closed

build(deps-dev): bump @playwright/test from 1.49.0 to 1.53.1 in /ui-tests #846

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ui-tests/package.json
View file
Original file line number Diff line number Diff line change
@@ -16,7 +16,7 @@
"license": "BSD-3-Clause",
"devDependencies": {
"@jupyterlab/galata": "^5.3.0",
"@playwright/test": "^1.49.0",
"@playwright/test": "^1.53.1",
"yarn-deduplicate": "^6.0.1"
}
}
28 changes: 14 additions & 14 deletions ui-tests/yarn.lock
View file
Original file line number Diff line number Diff line change
@@ -1170,12 +1170,12 @@
dependencies:
exenv-es6 "^1.1.1"

"@playwright/test@^1.48.0", "@playwright/test@^1.49.0":
version "1.49.0"
resolved "https://registry.npmjs.org/@playwright/test/-/test-1.49.0.tgz#74227385b58317ee076b86b56d0e1e1b25cff01e"
integrity sha512-DMulbwQURa8rNIQrf94+jPJQ4FmOVdpE5ZppRNvWVjvhC+6sOeo28r8MgIpQRYouXRtt/FCCXU7zn20jnHR4Qw==
"@playwright/test@^1.48.0", "@playwright/test@^1.53.1":
version "1.53.1"
resolved "https://registry.npmjs.org/@playwright/test/-/test-1.53.1.tgz#3ad5a2ce334b4a78390fd91e0a9d8423c09bc808"
integrity sha512-Z4c23LHV0muZ8hfv4jw6HngPJkbbtZxTkxPNIg7cJcTc9C28N/p2q7g3JZS2SiKBBHJ3uM1dgDye66bB7LEk5w==
dependencies:
playwright "1.49.0"
playwright "1.53.1"

"@rjsf/core@^5.13.4":
version "5.21.0"
@@ -2098,17 +2098,17 @@ picocolors@^1.0.1:
resolved "https://registry.npmjs.org/picocolors/-/picocolors-1.1.0.tgz#5358b76a78cde483ba5cef6a9dc9671440b27d59"
integrity sha512-TQ92mBOW0l3LeMeyLV6mzy/kWr8lkd/hp3mTg7wYK7zJhuBStmGMBG0BdeDZS/dZx1IukaX6Bk11zcln25o1Aw==

playwright-core@1.49.0:
version "1.49.0"
resolved "https://registry.npmjs.org/playwright-core/-/playwright-core-1.49.0.tgz#8e69ffed3f41855b854982f3632f2922c890afcb"
integrity sha512-R+3KKTQF3npy5GTiKH/T+kdhoJfJojjHESR1YEWhYuEKRVfVaxH3+4+GvXE5xyCngCxhxnykk0Vlah9v8fs3jA==
playwright-core@1.53.1:
version "1.53.1"
resolved "https://registry.npmjs.org/playwright-core/-/playwright-core-1.53.1.tgz#0b6f7a2006ccb6126ffcc3e3b2fa9efda23b6638"
integrity sha512-Z46Oq7tLAyT0lGoFx4DOuB1IA9D1TPj0QkYxpPVUnGDqHHvDpCftu1J2hM2PiWsNMoZh8+LQaarAWcDfPBc6zg==

playwright@1.49.0:
version "1.49.0"
resolved "https://registry.npmjs.org/playwright/-/playwright-1.49.0.tgz#df6b9e05423377a99658202844a294a8afb95d0a"
integrity sha512-eKpmys0UFDnfNb3vfsf8Vx2LEOtflgRebl0Im2eQQnYMA4Aqd+Zw8bEOB+7ZKvN76901mRnqdsiOGKxzVTbi7A==
playwright@1.53.1:
version "1.53.1"
resolved "https://registry.npmjs.org/playwright/-/playwright-1.53.1.tgz#86fb041b237a6868d163c87c4b9737fd1cac145e"
integrity sha512-LJ13YLr/ocweuwxyGf1XNFWIU4M2zUSo149Qbp+A4cpwDjsxRPj7k6H25LBrEHiEwxvRbD8HdwvQmRMSvquhYw==
dependencies:
playwright-core "1.49.0"
playwright-core "1.53.1"
optionalDependencies:
fsevents "2.3.2"

Unchanged files with check annotations Beta

View file
ui-tests/tests/widget_notebook_example.test.ts
// Copyright 2024 IBM, Red Hat
//
// Licensed under the Apache License, Version 2.0 (the "License");
const image = `widgets-cell-${i}.png`;
if (captures[i]) {
expect.soft(captures[i]).toMatchSnapshot(image); // Compare pre-existing capture

Check failure on line 63 in ui-tests/tests/widget_notebook_example.test.ts

GitHub Actions / verify-3_widget_example

tests/widget_notebook_example.test.ts:28:7 › Visual Regression › Run notebook 

  1) tests/widget_notebook_example.test.ts:28:7 › Visual Regression › Run notebook, capture cell outputs, and test widgets 
    Error: expect(Buffer).toMatchSnapshot(expected)

      3927 pixels (ratio 0.04 of all image pixels) are different.

    Expected: /home/runner/work/codeflare-sdk/codeflare-sdk/ui-tests/tests/widget_notebook_example.test.ts-snapshots/widgets-cell-5-linux.png
    Received: /home/runner/work/codeflare-sdk/codeflare-sdk/ui-tests/test-results/tests-widget_notebook_exam-c3288-ll-outputs-and-test-widgets/widgets-cell-5-actual.png
        Diff: /home/runner/work/codeflare-sdk/codeflare-sdk/ui-tests/test-results/tests-widget_notebook_exam-c3288-ll-outputs-and-test-widgets/widgets-cell-5-diff.png


      61 |
      62 |       if (captures[i]) {
    > 63 |         expect.soft(captures[i]).toMatchSnapshot(image); // Compare pre-existing capture
         |                                  ^
      64 |         continue;
      65 |       }
      66 |     }
        at /home/runner/work/codeflare-sdk/codeflare-sdk/ui-tests/tests/widget_notebook_example.test.ts:63:34

Check failure on line 63 in ui-tests/tests/widget_notebook_example.test.ts

GitHub Actions / verify-3_widget_example

tests/widget_notebook_example.test.ts:28:7 › Visual Regression › Run notebook 

  1) tests/widget_notebook_example.test.ts:28:7 › Visual Regression › Run notebook, capture cell outputs, and test widgets 
    Error: expect(Buffer).toMatchSnapshot(expected)

      518 pixels (ratio 0.03 of all image pixels) are different.

    Expected: /home/runner/work/codeflare-sdk/codeflare-sdk/ui-tests/tests/widget_notebook_example.test.ts-snapshots/widgets-cell-4-linux.png
    Received: /home/runner/work/codeflare-sdk/codeflare-sdk/ui-tests/test-results/tests-widget_notebook_exam-c3288-ll-outputs-and-test-widgets/widgets-cell-4-actual.png
        Diff: /home/runner/work/codeflare-sdk/codeflare-sdk/ui-tests/test-results/tests-widget_notebook_exam-c3288-ll-outputs-and-test-widgets/widgets-cell-4-diff.png


      61 |
      62 |       if (captures[i]) {
    > 63 |         expect.soft(captures[i]).toMatchSnapshot(image); // Compare pre-existing capture
         |                                  ^
      64 |         continue;
      65 |       }
      66 |     }
        at /home/runner/work/codeflare-sdk/codeflare-sdk/ui-tests/tests/widget_notebook_example.test.ts:63:34

Check failure on line 63 in ui-tests/tests/widget_notebook_example.test.ts

GitHub Actions / verify-3_widget_example

tests/widget_notebook_example.test.ts:28:7 › Visual Regression › Run notebook 

  1) tests/widget_notebook_example.test.ts:28:7 › Visual Regression › Run notebook, capture cell outputs, and test widgets 
    Error: expect(Buffer).toMatchSnapshot(expected)

      1026 pixels (ratio 0.02 of all image pixels) are different.

    Expected: /home/runner/work/codeflare-sdk/codeflare-sdk/ui-tests/tests/widget_notebook_example.test.ts-snapshots/widgets-cell-3-linux.png
    Received: /home/runner/work/codeflare-sdk/codeflare-sdk/ui-tests/test-results/tests-widget_notebook_exam-c3288-ll-outputs-and-test-widgets/widgets-cell-3-actual.png
        Diff: /home/runner/work/codeflare-sdk/codeflare-sdk/ui-tests/test-results/tests-widget_notebook_exam-c3288-ll-outputs-and-test-widgets/widgets-cell-3-diff.png


      61 |
      62 |       if (captures[i]) {
    > 63 |         expect.soft(captures[i]).toMatchSnapshot(image); // Compare pre-existing capture
         |                                  ^
      64 |         continue;
      65 |       }
      66 |     }
        at /home/runner/work/codeflare-sdk/codeflare-sdk/ui-tests/tests/widget_notebook_example.test.ts:63:34

Check failure on line 63 in ui-tests/tests/widget_notebook_example.test.ts

GitHub Actions / verify-3_widget_example

tests/widget_notebook_example.test.ts:28:7 › Visual Regression › Run notebook 

  1) tests/widget_notebook_example.test.ts:28:7 › Visual Regression › Run notebook, capture cell outputs, and test widgets 
    Error: expect(Buffer).toMatchSnapshot(expected)

      Expected an image 844px by 232px, received 844px by 209px. 4627 pixels (ratio 0.03 of all image pixels) are different.

    Expected: /home/runner/work/codeflare-sdk/codeflare-sdk/ui-tests/tests/widget_notebook_example.test.ts-snapshots/widgets-cell-2-linux.png
    Received: /home/runner/work/codeflare-sdk/codeflare-sdk/ui-tests/test-results/tests-widget_notebook_exam-c3288-ll-outputs-and-test-widgets/widgets-cell-2-actual.png
        Diff: /home/runner/work/codeflare-sdk/codeflare-sdk/ui-tests/test-results/tests-widget_notebook_exam-c3288-ll-outputs-and-test-widgets/widgets-cell-2-diff.png


      61 |
      62 |       if (captures[i]) {
    > 63 |         expect.soft(captures[i]).toMatchSnapshot(image); // Compare pre-existing capture
         |                                  ^
      64 |         continue;
      65 |       }
      66 |     }
        at /home/runner/work/codeflare-sdk/codeflare-sdk/ui-tests/tests/widget_notebook_example.test.ts:63:34

Check failure on line 63 in ui-tests/tests/widget_notebook_example.test.ts

GitHub Actions / verify-3_widget_example

tests/widget_notebook_example.test.ts:28:7 › Visual Regression › Run notebook 

  1) tests/widget_notebook_example.test.ts:28:7 › Visual Regression › Run notebook, capture cell outputs, and test widgets 
    Error: expect(Buffer).toMatchSnapshot(expected)

      23 pixels (ratio 0.01 of all image pixels) are different.

    Expected: /home/runner/work/codeflare-sdk/codeflare-sdk/ui-tests/tests/widget_notebook_example.test.ts-snapshots/widgets-cell-0-linux.png
    Received: /home/runner/work/codeflare-sdk/codeflare-sdk/ui-tests/test-results/tests-widget_notebook_exam-c3288-ll-outputs-and-test-widgets/widgets-cell-0-actual.png
        Diff: /home/runner/work/codeflare-sdk/codeflare-sdk/ui-tests/test-results/tests-widget_notebook_exam-c3288-ll-outputs-and-test-widgets/widgets-cell-0-diff.png


      61 |
      62 |       if (captures[i]) {
    > 63 |         expect.soft(captures[i]).toMatchSnapshot(image); // Compare pre-existing capture
         |                                  ^
      64 |         continue;
      65 |       }
      66 |     }
        at /home/runner/work/codeflare-sdk/codeflare-sdk/ui-tests/tests/widget_notebook_example.test.ts:63:34

Check failure on line 63 in ui-tests/tests/widget_notebook_example.test.ts

GitHub Actions / verify-3_widget_example

tests/widget_notebook_example.test.ts:28:7 › Visual Regression › Run notebook 

  1) tests/widget_notebook_example.test.ts:28:7 › Visual Regression › Run notebook, capture cell outputs, and test widgets 
    Error: expect(Buffer).toMatchSnapshot(expected)

      3927 pixels (ratio 0.04 of all image pixels) are different.

    Expected: /home/runner/work/codeflare-sdk/codeflare-sdk/ui-tests/tests/widget_notebook_example.test.ts-snapshots/widgets-cell-5-linux.png
    Received: /home/runner/work/codeflare-sdk/codeflare-sdk/ui-tests/test-results/tests-widget_notebook_exam-c3288-ll-outputs-and-test-widgets/widgets-cell-5-actual.png
        Diff: /home/runner/work/codeflare-sdk/codeflare-sdk/ui-tests/test-results/tests-widget_notebook_exam-c3288-ll-outputs-and-test-widgets/widgets-cell-5-diff.png


      61 |
      62 |       if (captures[i]) {
    > 63 |         expect.soft(captures[i]).toMatchSnapshot(image); // Compare pre-existing capture
         |                                  ^
      64 |         continue;
      65 |       }
      66 |     }
        at /home/runner/work/codeflare-sdk/codeflare-sdk/ui-tests/tests/widget_notebook_example.test.ts:63:34

Check failure on line 63 in ui-tests/tests/widget_notebook_example.test.ts

GitHub Actions / verify-3_widget_example

tests/widget_notebook_example.test.ts:28:7 › Visual Regression › Run notebook 

  1) tests/widget_notebook_example.test.ts:28:7 › Visual Regression › Run notebook, capture cell outputs, and test widgets 
    Error: expect(Buffer).toMatchSnapshot(expected)

      518 pixels (ratio 0.03 of all image pixels) are different.

    Expected: /home/runner/work/codeflare-sdk/codeflare-sdk/ui-tests/tests/widget_notebook_example.test.ts-snapshots/widgets-cell-4-linux.png
    Received: /home/runner/work/codeflare-sdk/codeflare-sdk/ui-tests/test-results/tests-widget_notebook_exam-c3288-ll-outputs-and-test-widgets/widgets-cell-4-actual.png
        Diff: /home/runner/work/codeflare-sdk/codeflare-sdk/ui-tests/test-results/tests-widget_notebook_exam-c3288-ll-outputs-and-test-widgets/widgets-cell-4-diff.png


      61 |
      62 |       if (captures[i]) {
    > 63 |         expect.soft(captures[i]).toMatchSnapshot(image); // Compare pre-existing capture
         |                                  ^
      64 |         continue;
      65 |       }
      66 |     }
        at /home/runner/work/codeflare-sdk/codeflare-sdk/ui-tests/tests/widget_notebook_example.test.ts:63:34

Check failure on line 63 in ui-tests/tests/widget_notebook_example.test.ts

GitHub Actions / verify-3_widget_example

tests/widget_notebook_example.test.ts:28:7 › Visual Regression › Run notebook 

  1) tests/widget_notebook_example.test.ts:28:7 › Visual Regression › Run notebook, capture cell outputs, and test widgets 
    Error: expect(Buffer).toMatchSnapshot(expected)

      1026 pixels (ratio 0.02 of all image pixels) are different.

    Expected: /home/runner/work/codeflare-sdk/codeflare-sdk/ui-tests/tests/widget_notebook_example.test.ts-snapshots/widgets-cell-3-linux.png
    Received: /home/runner/work/codeflare-sdk/codeflare-sdk/ui-tests/test-results/tests-widget_notebook_exam-c3288-ll-outputs-and-test-widgets/widgets-cell-3-actual.png
        Diff: /home/runner/work/codeflare-sdk/codeflare-sdk/ui-tests/test-results/tests-widget_notebook_exam-c3288-ll-outputs-and-test-widgets/widgets-cell-3-diff.png


      61 |
      62 |       if (captures[i]) {
    > 63 |         expect.soft(captures[i]).toMatchSnapshot(image); // Compare pre-existing capture
         |                                  ^
      64 |         continue;
      65 |       }
      66 |     }
        at /home/runner/work/codeflare-sdk/codeflare-sdk/ui-tests/tests/widget_notebook_example.test.ts:63:34

Check failure on line 63 in ui-tests/tests/widget_notebook_example.test.ts

GitHub Actions / verify-3_widget_example

tests/widget_notebook_example.test.ts:28:7 › Visual Regression › Run notebook 

  1) tests/widget_notebook_example.test.ts:28:7 › Visual Regression › Run notebook, capture cell outputs, and test widgets 
    Error: expect(Buffer).toMatchSnapshot(expected)

      Expected an image 844px by 232px, received 844px by 209px. 4627 pixels (ratio 0.03 of all image pixels) are different.

    Expected: /home/runner/work/codeflare-sdk/codeflare-sdk/ui-tests/tests/widget_notebook_example.test.ts-snapshots/widgets-cell-2-linux.png
    Received: /home/runner/work/codeflare-sdk/codeflare-sdk/ui-tests/test-results/tests-widget_notebook_exam-c3288-ll-outputs-and-test-widgets/widgets-cell-2-actual.png
        Diff: /home/runner/work/codeflare-sdk/codeflare-sdk/ui-tests/test-results/tests-widget_notebook_exam-c3288-ll-outputs-and-test-widgets/widgets-cell-2-diff.png


      61 |
      62 |       if (captures[i]) {
    > 63 |         expect.soft(captures[i]).toMatchSnapshot(image); // Compare pre-existing capture
         |                                  ^
      64 |         continue;
      65 |       }
      66 |     }
        at /home/runner/work/codeflare-sdk/codeflare-sdk/ui-tests/tests/widget_notebook_example.test.ts:63:34

Check failure on line 63 in ui-tests/tests/widget_notebook_example.test.ts

GitHub Actions / verify-3_widget_example

tests/widget_notebook_example.test.ts:28:7 › Visual Regression › Run notebook 

  1) tests/widget_notebook_example.test.ts:28:7 › Visual Regression › Run notebook, capture cell outputs, and test widgets 
    Error: expect(Buffer).toMatchSnapshot(expected)

      23 pixels (ratio 0.01 of all image pixels) are different.

    Expected: /home/runner/work/codeflare-sdk/codeflare-sdk/ui-tests/tests/widget_notebook_example.test.ts-snapshots/widgets-cell-0-linux.png
    Received: /home/runner/work/codeflare-sdk/codeflare-sdk/ui-tests/test-results/tests-widget_notebook_exam-c3288-ll-outputs-and-test-widgets/widgets-cell-0-actual.png
        Diff: /home/runner/work/codeflare-sdk/codeflare-sdk/ui-tests/test-results/tests-widget_notebook_exam-c3288-ll-outputs-and-test-widgets/widgets-cell-0-diff.png


      61 |
      62 |       if (captures[i]) {
    > 63 |         expect.soft(captures[i]).toMatchSnapshot(image); // Compare pre-existing capture
         |                                  ^
      64 |         continue;
      65 |       }
      66 |     }
        at /home/runner/work/codeflare-sdk/codeflare-sdk/ui-tests/tests/widget_notebook_example.test.ts:63:34
continue;
}
}
const upAndRunningMessage = await page.waitForSelector('text=Requested cluster is up and running!');
expect(upAndRunningMessage).not.toBeNull();
const dashboardReadyMessage = await page.waitForSelector('text=Dashboard is ready!');

Check failure on line 100 in ui-tests/tests/widget_notebook_example.test.ts

GitHub Actions / verify-3_widget_example

tests/widget_notebook_example.test.ts:28:7 › Visual Regression › Run notebook 

  1) tests/widget_notebook_example.test.ts:28:7 › Visual Regression › Run notebook, capture cell outputs, and test widgets 
    Error: proxy.waitForSelector: Test ended.
    Call log:
      - waiting for locator('text=Dashboard is ready!') to be visible


       98 |       expect(upAndRunningMessage).not.toBeNull();
       99 |
    > 100 |       const dashboardReadyMessage = await page.waitForSelector('text=Dashboard is ready!');
          |                                                ^
      101 |       expect(dashboardReadyMessage).not.toBeNull();
      102 |     });
      103 |
        at /home/runner/work/codeflare-sdk/codeflare-sdk/ui-tests/tests/widget_notebook_example.test.ts:100:48
        at interactWithWidget (/home/runner/work/codeflare-sdk/codeflare-sdk/ui-tests/tests/widget_notebook_example.test.ts:186:7)
        at /home/runner/work/codeflare-sdk/codeflare-sdk/ui-tests/tests/widget_notebook_example.test.ts:88:5
expect(dashboardReadyMessage).not.toBeNull();
});
numRefreshRetries++;
}
}
expect(clusterReady).toBe(true);

Check failure on line 144 in ui-tests/tests/widget_notebook_example.test.ts

GitHub Actions / verify-3_widget_example

tests/widget_notebook_example.test.ts:28:7 › Visual Regression › Run notebook 

  1) tests/widget_notebook_example.test.ts:28:7 › Visual Regression › Run notebook, capture cell outputs, and test widgets 
    Error: expect(received).toBe(expected) // Object.is equality

    Expected: true
    Received: false

      142 |         }
      143 |       }
    > 144 |       expect(clusterReady).toBe(true);
          |                            ^
      145 |     });
      146 |
      147 |     await interactWithWidget(page, viewClustersCellIndex, 'button:has-text("Open Ray Dashboard")', async (button) => {
        at /home/runner/work/codeflare-sdk/codeflare-sdk/ui-tests/tests/widget_notebook_example.test.ts:144:28
        at interactWithWidget (/home/runner/work/codeflare-sdk/codeflare-sdk/ui-tests/tests/widget_notebook_example.test.ts:186:7)
        at /home/runner/work/codeflare-sdk/codeflare-sdk/ui-tests/tests/widget_notebook_example.test.ts:129:5
});
await interactWithWidget(page, viewClustersCellIndex, 'button:has-text("Open Ray Dashboard")', async (button) => {