-
Notifications
You must be signed in to change notification settings - Fork 54
fix: port forward for local interactive tests #834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: port forward for local interactive tests #834
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #834 +/- ##
=======================================
Coverage 92.45% 92.45%
=======================================
Files 24 24
Lines 1419 1419
=======================================
Hits 1312 1312
Misses 107 107 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
80fe999
to
a8c55be
Compare
a8c55be
to
05469cb
Compare
Passing E2E run https://github.com/project-codeflare/codeflare-sdk/actions/runs/15421129110/job/43396238533?pr=834 7ec22e2 is just to reenable running all PRs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and thanks for all the work on this!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chipspeak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
78ec732
into
project-codeflare:main
Issue link
What changes have been made
Verification steps
Checks