NickAuth: Make username argument to 'nick add' required #1629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
optional() is greedy, so if someone uses 'nickauth nick add MyNick' and MyNick is also a bot account name, the command fails. This is very confusing.
|
Is there no nice way to preserve the current behaviour? I think the worst case implementation would be to manually count whether we've been passed one or two arguments. Even if it's not so idiomatic, it might be better than making the commands less flexible |
|
good idea |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
optional() is greedy, so if someone uses 'nickauth nick add MyNick' and MyNick is also a bot account name, the command fails. This is very confusing.