Make patch route #10 by DR0P-database · Pull Request #60 · profcomff/rating-api

DR0P-database · 2024-11-23T13:03:20Z

Изменения #10

ВАЖНО: изменена ручка для patch/review комментария админами

Чтобы изменить комментарий ему нужно отправить все поля для схемы CommentPost, их можно предварительно получить из GET, и в комментарии перепишутся поля. Также можно сделать комментарий анонимным через PATCH.

Детали реализации

Check-List

Вы проверили свой код перед отправкой запроса?
Вы написали тесты к реализованным функциям?
Вы не забыли применить форматирование black и isort для Back-End или Prettier для Front-End?

- Add test to patch user comments routes - Add fixture for this tests - Add enable set anonym to patch comment

github-actions · 2024-11-23T13:03:57Z

💩 Code linting failed, use black and isort to fix it.

github-actions · 2024-11-23T13:04:51Z

Coverage Report

File	Stmts	Miss	Cover	Missing
rating_api
__main__.py	4	4	0%	1–7
exceptions.py	43	7	84%	35–37, 48–50, 58
rating_api/models
base.py	55	5	91%	24–27, 76
db.py	85	3	96%	61, 75, 84
rating_api/routes
base.py	26	4	85%	48–50, 52
comment.py	120	23	81%	43, 47, 65, 83, 124–126, 147–156, 199, 209–214, 221, 245, 256, 297
exc_handlers.py	32	3	91%	36, 43, 50
lecturer.py	89	16	82%	136, 141–167, 183, 191, 209, 215
rating_api/schemas
base.py	12	4	67%	6–9
rating_api/utils
logging_utils.py	43	25	42%	21–42, 51, 58–64, 70–83
TOTAL	640	94	85%

Summary

Tests	Skipped	Failures	Errors	Time
51	0 💤	0 ❌	0 🔥	11.100s ⏱️

Temmmmmo

Сделай тогда новую модельку и поправь тесты и код

rating_api/routes/comment.py

- Fix up tests - Make allow unnecessary attibutes to patch - Add new scheme to CommentUpdate

rating_api/routes/comment.py

tests/conftest.py

tests/test_routes/test_comment.py

rating_api/routes/comment.py

tests/test_routes/test_comment.py

- Validation if given attribute is still not changed - Validation if no attributes given - Add tests

github-actions · 2024-12-06T12:39:07Z

💩 Code linting failed, use black and isort to fix it.

rating_api/routes/comment.py

rating_api/schemas/models.py

rating_api/routes/comment.py

github-actions · 2025-02-07T21:35:57Z

💩 Code linting failed, use black and isort to fix it.

- tests - pathc in not provide any parametr

Outdated

… develop_patch

github-actions · 2025-03-01T19:04:34Z

💩 Code linting failed, use black and isort to fix it.

github-actions · 2025-03-01T19:11:31Z

💩 Code linting failed, use black and isort to fix it.

github-actions · 2025-03-01T19:13:14Z

💩 Code linting failed, use black and isort to fix it.

DR0P-database added 5 commits November 22, 2024 11:43

Revert tests

0467890

Add PATCH to own comment

8ef3dfa

Fix route in PATCH tests

8627d30

Add test_patch_comment

569242c

- Add test to patch user comments routes - Add fixture for this tests - Add enable set anonym to patch comment

Make format

9257710

DR0P-database requested review from Temmmmmo, Zimovchik and parfenovma November 23, 2024 13:03

DR0P-database self-assigned this Nov 23, 2024

Make format

04f6686

Temmmmmo reviewed Nov 24, 2024

View reviewed changes

rating_api/routes/comment.py Outdated Show resolved Hide resolved

rating_api/routes/comment.py Outdated Show resolved Hide resolved

rating_api/routes/comment.py Outdated Show resolved Hide resolved

rating_api/routes/comment.py Outdated Show resolved Hide resolved

Temmmmmo reviewed Nov 24, 2024

View reviewed changes

rating_api/routes/comment.py Outdated Show resolved Hide resolved

DR0P-database added 3 commits November 25, 2024 01:04

Fix up patch route

18c992f

- Fix up tests - Make allow unnecessary attibutes to patch - Add new scheme to CommentUpdate

Merge branch 'main' into develop_patch

4877606

Fix up one test

43794f6

DaymasS reviewed Nov 24, 2024

View reviewed changes

rating_api/routes/comment.py Outdated Show resolved Hide resolved

Zimovchik requested changes Nov 25, 2024

View reviewed changes

tests/conftest.py Outdated Show resolved Hide resolved

tests/test_routes/test_comment.py Show resolved Hide resolved

DR0P-database added 2 commits November 25, 2024 13:02

Modify exclude params

3cecc47

Fixup tests

6c13bf8

Temmmmmo reviewed Dec 1, 2024

View reviewed changes

rating_api/routes/comment.py Show resolved Hide resolved

tests/test_routes/test_comment.py Show resolved Hide resolved

tests/test_routes/test_comment.py Show resolved Hide resolved

Add validation

b44aab3

- Validation if given attribute is still not changed - Validation if no attributes given - Add tests

DR0P-database added 2 commits December 6, 2024 15:39

Merge branch 'main' into develop_patch

404a0ea

Make format

9984108

Zimovchik reviewed Dec 6, 2024

View reviewed changes

rating_api/routes/comment.py Outdated Show resolved Hide resolved

parfenovma reviewed Dec 6, 2024

View reviewed changes

rating_api/routes/comment.py Show resolved Hide resolved

rating_api/schemas/models.py Show resolved Hide resolved

rating_api/routes/comment.py Outdated Show resolved Hide resolved

rating_api/routes/comment.py Outdated Show resolved Hide resolved

DR0P-database added 2 commits December 9, 2024 13:40

Fix up tests

b6f8b08

IMPORTATNT fix ip tests

5cc17d0

parfenovma approved these changes Dec 9, 2024

View reviewed changes

Zimovchik approved these changes Dec 9, 2024

View reviewed changes

Temmmmmo previously requested changes Dec 10, 2024

View reviewed changes

rating_api/routes/comment.py Outdated Show resolved Hide resolved

rating_api/routes/comment.py Outdated Show resolved Hide resolved

DROPDATABASE added 2 commits February 7, 2025 23:56

Merge branch 'main' into develop_patch

6b93879

Fixup

c6fb542

DROPDATABASE added 2 commits February 8, 2025 00:45

Fixup

0ed81cb

- tests - pathc in not provide any parametr

Cherry pick github actions

90efde1

Zimovchik requested a review from Temmmmmo February 16, 2025 15:15

Merge branch 'main' into develop_patch

2f4b653

DROPDATABASE added 3 commits March 1, 2025 21:09

Make custom raise exceptions

6016f69

Merge remote-tracking branch 'refs/remotes/origin/develop_patch' into…

2c8eb68

… develop_patch

fixup test create_comment#7

23bbf2c

Fixup

6cd41b6

Format linting

f9015e8

Temmmmmo merged commit 0df91a1 into main Mar 7, 2025
2 checks passed

Temmmmmo linked an issue Mar 11, 2025 that may be closed by this pull request

Ручка PATCH для неанонимных комментариев #10

Closed

Conversation

DR0P-database commented Nov 23, 2024

Изменения #10

Детали реализации

Check-List

Uh oh!

github-actions bot commented Nov 23, 2024

Uh oh!

github-actions bot commented Nov 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

Temmmmmo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Dec 6, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Feb 7, 2025

Uh oh!

github-actions bot commented Mar 1, 2025

Uh oh!

github-actions bot commented Mar 1, 2025

Uh oh!

github-actions bot commented Mar 1, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

github-actions bot commented Nov 23, 2024 •

edited

Loading