Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Доработка dwh-definitons библиотеки #118

Merged
merged 3 commits into from
Dec 15, 2024
Merged

Доработка dwh-definitons библиотеки #118

merged 3 commits into from
Dec 15, 2024

Conversation

zipperman1
Copy link
Contributor

@zipperman1 zipperman1 commented Dec 14, 2024 •
edited
Loading

Изменения

Добавил SensitiveBase(Base), переписал кастомные скрипты для алембика

Детали реализации

см. выше

Check-List

  • Вы проверили свой код перед отправкой запроса?
  • Вы написали тесты к реализованным функциям?
  • Вы не забыли применить форматирование black и isort для Back-End или Prettier для Front-End?

@zipperman1 zipperman1 self-assigned this Dec 14, 2024
@zipperman1 zipperman1 linked an issue Dec 14, 2024 that may be closed by this pull request
Доработка dwh-definitons библиотеки #114
Closed
@github-actions GitHub Actions
Copy link

💩 Code linting failed, use black and isort to fix it.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 14, 2024 •
edited
Loading

Summary

Tests Skipped Failures Errors Time
1 0 💤 0 ❌ 0 🔥 9.479s ⏱️

parfenovma
parfenovma requested changes Dec 15, 2024
View reviewed changes
Copy link
Contributor

@parfenovma parfenovma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

обязательно ещё какой-нибудь тест кейс надо, пока непонятно как это всё работает
и непонятно есть ли обратная совместимость, как будто нет

profcomff_definitions/base.py Outdated Show resolved Hide resolved
migrations/custom_scripts/tables.py Outdated Show resolved Hide resolved
migrations/custom_scripts/tables.py Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

💩 Code linting failed, use black and isort to fix it.

@github-actions GitHub Actions
Copy link

💩 Code linting failed, use black and isort to fix it.

@zipperman1 zipperman1 merged commit 62d8c19 into main Dec 15, 2024
1 of 2 checks passed
@zipperman1 zipperman1 deleted the accessrights branch December 15, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parfenovma parfenovma parfenovma approved these changes

Assignees

@zipperman1 zipperman1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Доработка dwh-definitons библиотеки
2 participants
@zipperman1 @parfenovma