Fix for NullPointerException thrown in PApplet.dequeueWindowEvents()#930
Merged
Stefterv merged 1 commit intoprocessing:mainfrom Jan 21, 2025
Merged
Fix for NullPointerException thrown in PApplet.dequeueWindowEvents()#930Stefterv merged 1 commit intoprocessing:mainfrom
PApplet.dequeueWindowEvents()#930Stefterv merged 1 commit intoprocessing:mainfrom
Conversation
Stefterv
approved these changes
Jan 20, 2025
Contributor
|
Hi @hx2A Thank you for the fix, I tested it on macOS arm64 and works just fine here too. |
Contributor
Author
You are welcome! Happy to help out here. |
PApplet.dequeueWindowEvents()
SableRaf
approved these changes
Jan 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is a fix for #918.
When the window is moved or resized, the new location or size values will be stored as a pair in the
windowEventQueuemap. This ensures that there are no race conditions if one value has been added but the other has not.The exception I saw when I opened #918 is probably very rare and would be hard to reproduce. Nevertheless, we can review the code change and verify that the necessary functionality still works. You can test window move and resize events with the following code:
It also works with the
P2Drenderer.