Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor PShapeSVG.parseRect() to parse rx and ry attributes #905

Merged
merged 2 commits into from
Jan 11, 2025
Merged

Refactor PShapeSVG.parseRect() to parse rx and ry attributes #905

merged 2 commits into from
Jan 11, 2025

Conversation

Junology
Copy link
Contributor

Fix #904.
The test code and the resource are found there.

@Junology Junology mentioned this pull request Jan 10, 2025
Closed
@SableRaf
Copy link
Collaborator

@Stefterv Shouldn't PR test builds skip the code signing and notarization? See: #906

Stefterv
Stefterv approved these changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@Stefterv Stefterv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me. Can you sync your branch with main so we can do a quick test with the example sketch you provided in #904

@Junology
Copy link
Contributor Author

@Stefterv Thank you for your work. I synced the PR with main.

@Stefterv
Copy link
Collaborator

Stefterv commented Jan 11, 2025 •
edited
Loading

Screenshot 2025-01-11 at 07 14 37 Test macOS arm64

Considering this code is platform-agnostic I don't think we need to test it on all platforms.

Thank you for your work @Junology!

@SableRaf feel free to merge

@SableRaf SableRaf merged commit 5e1161c into processing:main Jan 11, 2025
6 checks passed
@Junology Junology deleted the rxattrib branch January 11, 2025 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stefterv Stefterv Stefterv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PShapeSVG ignores rx and ry attributes of <rect> element
3 participants
@Junology @SableRaf @Stefterv