Merge pull request #908 from processing/skip-signing

Skip signing if the required secrets are not available
processing · Jan 10, 2025 · 5f32f67 · 5f32f67
2 parents df36fd0 + 1248d45
commit 5f32f67
Showing 1 changed file with 8 additions and 15 deletions.
diff --git a/.github/workflows/pull_request.yml b/.github/workflows/pull_request.yml
@@ -51,27 +51,20 @@ jobs:
           architecture: ${{ matrix.arch }}
       - name: Setup Ant
         uses: cedx/setup-ant@v3
-      - name: Install Certificates for Code Signing
-        if: ${{ matrix.os_prefix == 'macos' }}
-        uses: apple-actions/import-codesign-certs@v3
-        with:
-          p12-file-base64: ${{ secrets.CERTIFICATES_P12 }}
-          p12-password: ${{ secrets.CERTIFICATES_P12_PASSWORD }}
+      # - name: Install Certificates for Code Signing
+      #   if: ${{ matrix.os_prefix == 'macos' }}
+      #   uses: apple-actions/import-codesign-certs@v3
+      #   with:
+      #     p12-file-base64: ${{ secrets.CERTIFICATES_P12 }}
+      #     p12-password: ${{ secrets.CERTIFICATES_P12_PASSWORD }}
       - name: Build Release
         run: ant -noinput -buildfile build/build.xml ${{ matrix.os_prefix }}-dist -Dversion="${{ github.sha }}"
-        env:
-          PROCESSING_APP_SIGNING: true
+        # env:
+        #   PROCESSING_APP_SIGNING: ${{ secrets.CERTIFICATES_P12 != '' }}
       - name: Add artifact
         uses: actions/upload-artifact@v3
         id: upload
         with:
           name: processing-${{github.sha}}${{ matrix.os_prefix }}-${{ matrix.arch }}
           path:  ./build/${{ matrix.os_prefix }}/processing-${{github.sha}}-${{ matrix.os_prefix}}-*
           retention-days: 5
-      # TODO: Merge into one comment and fix the link
-      # - uses: mshick/add-pr-comment@v2
-      #   with: 
-      #       message-id: "build-artifact ${{ matrix.os_prefix }} ${{ matrix.arch }}"
-      #       message: |
-      #           Build artifacts for ${{ matrix.os_prefix }} (${{ matrix.arch }}) have been created.
-      #           Download the artifacts [here](${{ steps.upload.outputs.artifact-id }}).