Add logging for experimental features - #9109
Open
davepagurek wants to merge 8 commits into
Open
Conversation
Vaivaswat2244
left a comment
Vaivaswat2244
left a comment
Contributor
There was a problem hiding this comment.
Hi @davepagurek , I had a few thoughts on this.
| fn.buildMaterialShader = function (cb, scope) { | ||
| return this.baseMaterialShader().modify(cb, scope); | ||
| }; | ||
| p5.registerDecorator('p5.prototype.buildMaterialShader', markExperimental('p5.strands', p5)); |
Contributor
There was a problem hiding this comment.
buildNormalShader also has beta tag, that should also be here?
Contributor
Author
There was a problem hiding this comment.
yep, good catch!
| } | ||
| return this._renderer.createStorage(dataOrCount); | ||
| }; | ||
| p5.registerDecorator('p5.prototype.createStorage', markExperimental('webgpu', p5)); |
Contributor
There was a problem hiding this comment.
baseComputeShader() (L2379) and compute() (L2725) are @beta and live on Renderer3D, so they are reachable in WEBGL mode where the RendererWebGPU constructor warning never fires...
Contributor
Author
There was a problem hiding this comment.
Compute shaders only actually work in WebGPU mode and will throw an error in WebGL mode so I figured that path was less critical to flag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #9108
Changes:
Live example: https://editor.p5js.org/davepagurek/sketches/p1c5jvRAf
PR Checklist
npm run lintpasses