Skip to content

added instance of video in callback #7585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2025
Merged

added instance of video in callback #7585

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions src/dom/dom.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2082,15 +2082,6 @@ function createMedia(pInst, type, src, callback) {
elt.appendChild(sourceEl);
}

// If callback is provided, attach to element
if (typeof callback === 'function') {
const callbackHandler = () => {
callback();
elt.removeEventListener('canplaythrough', callbackHandler);
};
elt.addEventListener('canplaythrough', callbackHandler);
}

const mediaEl = addElement(elt, pInst, true);
mediaEl.loadedmetadata = false;

Expand All @@ -2109,6 +2100,15 @@ function createMedia(pInst, type, src, callback) {
mediaEl.loadedmetadata = true;
});

// If callback is provided, attach to element
if (typeof callback === 'function') {
const callbackHandler = () => {
callback(mediaEl);
elt.removeEventListener('canplaythrough', callbackHandler);
};
elt.addEventListener('canplaythrough', callbackHandler);
}

return mediaEl;
}

Expand Down