Skip to content

Two new examples for loadPixels #2793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

Two new examples for loadPixels #2793

wants to merge 9 commits into from

Conversation

AdilRabbani
Copy link
Member

Added two new examples for loadPixels(). One generates a simple texture using pixels and the other averages image pixels.

Added two new examples for loadPixels(). One generates a simple texture using pixels and the other averages image pixels.
Added two new examples for loadPixels(). One that creates a simple texture using pixels and the other averages image pixels.
Added two new examples for loadPixels(). One that creates a simple texture using pixels and the other averages image pixels.
Added two new examples for loadPixels(). One that creates a simple texture using pixels and the other averages image pixels.
Added two new examples for loadPixels(). One that creates a simple texture using pixels and the other averages image pixels.
Added two new examples for loadPixels(). One creates a simple texture using pixels and the other averages image pixels.
Added two new examples for loadPixels(). One creates a simple texture using pixels and the other averages image pixels.
Added two new examples for loadPixels(). One creates a simple texture using pixels and the other averages image pixels.
Added two new examples for loadPixels(). One creates a simple texture using pixels and the other averages image pixels.
@limzykenneth
Copy link
Member

In #1954 the loadPixels() function that needed example is for the version of loadPixels() for the WebGL renderer (currently not showing up in the reference because it is marked as a private function, probably still work in progress). I feel we don't need extra example in this instance of loadPixes() as it doesn't demonstrate additional functionality of the method that isn't already covered by the original example.

P.S. There seems to be a lot of noise in in the commits that are just adding and removing whitespace.

@AdilRabbani
Copy link
Member Author

Yes, Although there were no technical errors in the examples I wrote, the commit after going through the Travis CI, was not passing a few tests just because of some minor whitespaces. That's the reason I had to commit it, a few times, passing the test cases...

@limzykenneth
Copy link
Member

You can run grunt test locally to run the same tests that are ran on Travis and you can also run npm run lint:fix to try to automatically fix any code style issues.

@Spongman
Copy link
Contributor

I think that actually the #1954 issue is in error. The renderer methods are not exposed as part of the API, and shouldn't appear in the reference docs.

The correct list of methods missing examples can be found by running grunt yui doc:prod.

@limzykenneth
Copy link
Member

Yeah, I'm thinking maybe they are outdated since we've only added the @private tag recently

@AdilRabbani AdilRabbani deleted the patch-4 branch May 23, 2018 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants