Use import.meta.env + ENV file so hydrated components work #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #627
Adds @shibomb's check to see if
process.envis defined for node environments, but also falls back onimport.meta.envfor non-SSR components hydrated in the browser. To do this, the env vars are written to a .env file that Astro reads, and the vars that need to be read in the browser have to have aPUBLIC_prefix for Astro to pass them through.Also makes more schema things optional for dev builds and corrects the cleanup script from removing those changes (it was cleaning up the whole
referencefolder instead of just the content inreference/en/, oops)