-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add attribution links to each example description #425
base: main
Are you sure you want to change the base?
Conversation
Thanks @calebfoss. I'm still waiting for some previous contributors' feedback on this issue, like how to properly credit the contributors who worked on p5.js examples prior to the STF project, especially based on the fact that lots of p5.js examples were directly ported from examples on Processing website. Meanwhile, @SableRaf is looking into getting clarification on processing website repo license issue. I will come back to this PR after get more response from other contributors. |
Hi @calebfoss , As part of considering #415, I’ve checked your attribution lists against the all_contributors list on the p5.js GitHub readme, and I see that the following contributors are not in the All Contributors list:
All but one I can add using the bot in processing/p5.js#2309 (“add ___ for example”). The contributor without link I can add manually unless you have their GitHub @. (Edited to add: I just checked that it's possible to add a name only without a GitHub handle in my fork: https://github.com/ksen0/p5.js/) For all contributors those that are already on the list, I can go through and ensure there’s an “example” emoji/contribution note:
Please let me know if I should go ahead with adding the above? EDITED TO ADD: these were added |
I used the Github API to pull the blame for each example with Github username data. I then mapped that data to links and added them to the descriptions for each example. Finally, I made some manual tweaks based on contributors that were missing from the blame, such as @Malayvasa who contributed examples via p5 editor links.