-
Notifications
You must be signed in to change notification settings - Fork 204
Fix #1030: route p5.sound reference source links to correct GitHub repo (2.x) #1073
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Note: this PR includes some minor formatting-only changes in the same file from reapplying the fix cleanly. Happy to split or adjust if you’d prefer the diff to be strictly minimal. |
|
hi @rakesh2OO5 did you test these changes locally, can you attach a screenshot or a video sample so it's easy for the maintainers the review the PR. |
|
@rakesh2OO5 everything looks fine to me. Could you please tell me how were you able to get the beta.p5js.org page run locally ? On my end, even after setting the versions of p5Version = "2.1.2" and p5SoundVersion = "0.2.0" and running npm run build and npm run dev still opens the p5js.org page locally not the beta.p5js.org that has the wrong links problem. |
|
Hi @kunstewi, thanks for checking and for the question! I didn’t actually run the beta.p5js.org site locally as a separate app. What I did instead was: 1.Run the site locally using npm run dev as usual 2.Switch to the 2.x reference context by navigating to routes like 3.Verify the “Edit this file” / source links rendered on those pages The key thing is that the bug isn’t about which domain (p5js.org vs beta.p5js.org) is served locally, but about how the reference layout generates GitHub source links for 2.x entries. Locally, the dev server will still open under localhost, but the rendered links reflect the 2.x data (module = p5.sound) and that’s where the incorrect repo routing was happening. Let me know if you’d like, I can also add a short note to the PR clarifying this distinction for reviewers. |
|
hey @davepagurek please take a look at this. |
|
hey @rakesh2OO5 check out the proposed changes by dave, and please make the adjustments accordingly, thank you. |





Summary
This PR fixes incorrect GitHub source and issue links shown on the p5.sound 2.x reference site.
The visible “Edit this file” and issue links are generated in
ReferenceItemLayout.astro, not in the reference builder comments.Because of this, p5.sound entries were incorrectly routing users to
processing/p5.jsinstead ofprocessing/p5.sound.Changes
entry.data.moduleprocessing/p5.soundNotes
Fixes #1030