Skip to content

i18n Sync: Update Settings and SubmitSaveAllSettings Keys Across Locale Files #3510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
yugalkaushik opened this issue Jun 4, 2025 · 2 comments · May be fixed by #3523
Open

i18n Sync: Update Settings and SubmitSaveAllSettings Keys Across Locale Files #3510

yugalkaushik opened this issue Jun 4, 2025 · 2 comments · May be fixed by #3523
Labels
Area: Translation For localization of the p5.js editor or contributor documentation Good First Issue A beginner-friendly issue, great for first-time contributors Help Wanted Would love additional input or contributions! Ready for Work Issue is ready for development work

Comments

@yugalkaushik
Copy link
Contributor

yugalkaushik commented Jun 4, 2025 •
edited
Loading

p5.js version

No response

What is your operating system?

Windows

Web browser and version

Chrome 1.79.119

Actual Behavior

  • Some locale files still use outdated keys, such as:

"SubmitSaveAllSettings": "Save All Settings"

"Settings": "Account Settings"

  • These values have been updated only in the English locale, where:

"SubmitSaveAllSettings": "Save All Settings" was replaced with "SaveAccountDetails": "Save Account Details"

"Settings": "Account Settings" (under AccountView) was updated to "Settings": "My Account"

  • Other locale files have not yet been updated, leading to inconsistent UI translations across languages.

Expected Behavior

  • All supported locale files should include the updated keys with proper translations:

"SaveAccountDetails": "Save Account Details",
"Settings": "My Account"

  • Outdated keys like "SubmitSaveAllSettings" should be removed.

  • The UI should reflect consistent wording across all languages when these sections are displayed.

Steps to reproduce

#3509 Refer to this PR for the changes.

Steps to Reproduce

  1. Switch to a non-English language (e.g., Spanish, French)

  2. Navigate to My Account page (previously Settings)

  3. Observe:
    - The header still says "Account Settings".
    - The save button still says "Save All Settings".

  4. Compare this with the English version, which correctly says:
    - "My Account"
    - "Save Account Details"
@yugalkaushik yugalkaushik added Bug Error or unexpected behaviors Awaiting Maintainer Approval Needs review from a maintainer before moving forward labels Jun 4, 2025
@raclim raclim added Help Wanted Would love additional input or contributions! Good First Issue A beginner-friendly issue, great for first-time contributors Area: Translation For localization of the p5.js editor or contributor documentation Ready for Work Issue is ready for development work and removed Bug Error or unexpected behaviors Awaiting Maintainer Approval Needs review from a maintainer before moving forward labels Jun 4, 2025
ojuschugh1 added a commit to ojuschugh1/p5.js-web-editor that referenced this issue Jun 10, 2025
@ojuschugh1
solved i18n Sync: Update Settings and SubmitSaveAllSettings Keys Acro…
fffa082 
…ss Locale Files processing#3510
@ojuschugh1 ojuschugh1 mentioned this issue Jun 10, 2025
Closed
4 tasks
@ojuschugh1
Copy link

ojuschugh1 commented Jun 10, 2025 •
edited
Loading

Hi @yugalkaushik @raclim I have fixed this issue in this PR #3518

@ojuschugh1 ojuschugh1 mentioned this issue Jun 10, 2025
Closed
4 tasks
ojuschugh1 added a commit to ojuschugh1/p5.js-web-editor that referenced this issue Jun 10, 2025
@ojuschugh1
Revert "solved i18n Sync: Update Settings and SubmitSaveAllSettings K…
8d29d6d 
…eys Across Locale Files processing#3510"

This reverts commit fffa082.
ojuschugh1 added a commit to ojuschugh1/p5.js-web-editor that referenced this issue Jun 12, 2025
@ojuschugh1
Solve this issue for hindi translation i18n Sync: Update Settings and…
a87d8b8 
… SubmitSaveAllSettings Keys Across Locale Files processing#3510
@ojuschugh1 ojuschugh1 linked a pull request Jun 12, 2025 that will close this issue
Open
4 tasks
@ojuschugh1
Copy link

For Hindi Translation, the Fix is here -: #3523

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: Translation For localization of the p5.js editor or contributor documentation Good First Issue A beginner-friendly issue, great for first-time contributors Help Wanted Would love additional input or contributions! Ready for Work Issue is ready for development work
Projects
None yet
Milestone
No milestone
3 participants
@raclim @ojuschugh1 @yugalkaushik