fix: updated deploy worflow to match actual google cloud actions rules #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix/deploy workflow
Alwil17
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces changes to modernize the deployment workflow and improve compatibility in the Probot application code. Key updates include transitioning to a newer Node.js runtime, enhancing authentication in the deployment process, and refactoring the Probot app initialization for better readability and maintainability.
Deployment Workflow Updates:
.github/workflows/deploy.yml: Updated the Node.js runtime fromnodejs12tonodejs20for deploying the Google Cloud Function, ensuring compatibility with modern environments..github/workflows/deploy.yml: Replacedservice_account_keywithgoogle-github-actions/auth@v2for authentication, using acredentials_jsonapproach for improved security and clarity.Probot Application Refactoring:
function.js: Refactored the Probot app initialization to use theProbotclass directly, replacingcreateProbot()for better control over environment variables and handling RSA key formatting.function.js: Updated the export syntax to CommonJS for compatibility with Node.js and clarified the naming of the imported app function (appFn).