Add big endian support #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TI names their sections with a `:`. For example, `.text:Fapi_issueAsyncCommand`. Add this as a recognized section prefix when placing symbols into the text section. Signed-off-by: Sean Cross <[email protected]>
With big endian devices, the symbols are stored in big endian order. This is fine if the header is getting loaded onto the target, however the header is only for use with the host system, which is almost alays little endian. Ensure each field of the header is correctly swapped by adding `.to_le()` to each field. Additionally, ensure all fields are primitive integer types, as byte swapping is undefined for Rust types. Signed-off-by: Sean Cross <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for generating flash algorithms that work on big endian machines.
There are two patches in this patchset:
.text:rather than.text.. We can try changing it to*(.text*), but I thought it better to explicitly target symbols this way..to_le()to the end of each section. This ensures that all numbers are stored in the header in little endian format, which is preferrable as the header is usually read on a little endian host system. This also necessitates casting theDeviceTypeto au16so we can perform the swap, however the actual type isn't currently used so this is fine.I have tested this on a TMS570, and the values come through fine with this change. The
namefield is not swapped, which indicates to me that this is the correct approach.