Add Script to enroll Yubikey PIV Certificates #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The script creates a certificate signing request on the Yubikey and sends it to privacyIDEA to get it signed. It also creates an attestation certificate to attest the CSR coming from the Yubikey hardware (currently privacyIDEA does not support this). This script is still work in progress. Working on #42 #43
cornelinux
reviewed
Jul 2, 2020
| | Proper Certificate checking can NOT be guaranteed! | | ||
| | Currently all (generated) certs will be written out to ease | | ||
| | development and debugging. | | ||
| | One day this script might also become part of the privacyIDEA admin tool. | |
There was a problem hiding this comment.
I would dump the last sentence.
laclaro
requested changes
Jul 16, 2020
| @click.option('-d', '--device', type=int, metavar='SERIAL') | ||
| @click_pin_option | ||
| @click_management_key_option | ||
| @click.option('-s', '--subject', help='Subject string for the Certificate') |
There was a problem hiding this comment.
Please make subject a required argument.
| @click.option('-t', '--token', help='Admin token for the privacyIDEA API') | ||
| @click.option('-c', '--ca', help='CA connector in privacyIDEA') | ||
| @click.option('-k', '--keyfile', help='Verify response from privacyIDEA with key', | ||
| default=None) |
There was a problem hiding this comment.
Please add an option to ignore SSL cert validation.
- Add some more information about installation to Readme and setup.py. - The enroll-yubikey-piv script checks whether the necessary packages are installed since `pyscard` requires a C building tool-chain. - Suppress usage output when failing in enroll-yubikey-piv script - Make the `subject` parameter required and add a `nosslcheck` parameter
Done in 39d2122
Done in 39d2122
I think this is a privacyIDEA issue since it is currently providing the broken |
laclaro
approved these changes
Jul 17, 2020
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The script creates a certificate signing request on the Yubikey and sends
it to privacyIDEA to get it signed. It also creates an attestation
certificate to attest the CSR coming from the Yubikey hardware (currently
privacyIDEA does not support this).
This script is still work in progress.
Working on #42 and #43