Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tokenInit to import otpkey #60

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Conversation

scpcom
Copy link
Contributor

@scpcom scpcom commented Jun 11, 2024

A web application (in my case guacamole) who uses the privacyIDEA java-client may have already a otpkey associated with the user in its DB.
This commit would add a function to import it to privacyIDEA via token init.

@nilsbehlen
Copy link
Member

thanks for your contribution.
i think we should rename the existing token init function from tokenRollout to tokenInit so that the one you added is an overloaded one.

@scpcom
Copy link
Contributor Author

scpcom commented Jun 12, 2024

Personally I prefer to keep backward compatibility.
On the other hand I started using the java-client only few weeks ago, so it would be also OK if tokenRollout gets renamed.

@nilsbehlen
Copy link
Member

We will keep the old function and mark it as deprecated.

@scpcom
Copy link
Contributor Author

scpcom commented Jun 13, 2024

OK, do I need to do additional steps/update code in my branch?

@nilsbehlen
Copy link
Member

No, i just writing this a memo to myself when i get to this i will make the changes when merging, you are fine.

@nilsbehlen nilsbehlen merged commit 49cae9d into privacyidea:master Jul 26, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants