Use reject to prevent errors from being swallowed #143
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an error is thrown inside a Promise it normally rejects, but if the error is thrown from inside a callback, i.e. in an async manner, the only way to make the Promise reject is to call the reject callback, otherwise the Error thrown ends up nowhere and the Promise never resolves or rejects, resulting in weird errors on Graphcool (which could handle this better too)...
This PR uses the reject callback to solve this problem.