-
Notifications
You must be signed in to change notification settings - Fork 638
chore: remove styled-system and useTheme from BaseStyles #7010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove styled-system and useTheme from BaseStyles #7010
Conversation
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
…om:primer/react into chore/remove-styled-system-from-basestyles
This reverts commit 3b8f5ab.
<div> | ||
<div | ||
class="prc-src-BaseStyles-9LBd2" | ||
data-color-mode="light" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this break anything in the AnchoredOverlay styles?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any usage of these props in the AnchoredOverlay module css file, this is just about the test file being wrapped in BaseStyles Im pretty sure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strange, didn't expect this story to update 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed!
…tem-from-basestyles
🟢 ci completed with status |
60ffc7e
into
bye-bye-styled-components
Changelog
New
Changed
Removed
Rollout strategy
Testing & Reviewing
Merge checklist