Skip to content

Conversation

francinelucca
Copy link
Member

@francinelucca francinelucca commented Oct 15, 2025

Changelog

New

Changed

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

Copy link

changeset-bot bot commented Oct 15, 2025

⚠️ No Changeset found

Latest commit: 1a3714a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Oct 15, 2025
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot requested a deployment to storybook-preview-7010 October 15, 2025 01:01 Abandoned
@github-actions github-actions bot temporarily deployed to storybook-preview-7010 October 15, 2025 01:09 Inactive
<div>
<div
class="prc-src-BaseStyles-9LBd2"
data-color-mode="light"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this break anything in the AnchoredOverlay styles?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any usage of these props in the AnchoredOverlay module css file, this is just about the test file being wrapped in BaseStyles Im pretty sure

@github-actions github-actions bot removed the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Oct 16, 2025
@siddharthkp siddharthkp added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Oct 16, 2025
@github-actions github-actions bot temporarily deployed to storybook-preview-7010 October 16, 2025 23:30 Inactive
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Oct 16, 2025
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange, didn't expect this story to update 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed!

@siddharthkp siddharthkp changed the base branch from main to bye-bye-styled-components October 16, 2025 23:36
@siddharthkp siddharthkp changed the base branch from bye-bye-styled-components to main October 16, 2025 23:37
@siddharthkp siddharthkp changed the base branch from main to bye-bye-styled-components October 16, 2025 23:42
@github-actions github-actions bot temporarily deployed to storybook-preview-7010 October 16, 2025 23:43 Inactive
@primer-integration
Copy link

🟢 ci completed with status success.

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: failing Changes in this PR cause breaking changes in gh/gh labels Oct 17, 2025
@siddharthkp siddharthkp marked this pull request as ready for review October 17, 2025 07:50
@siddharthkp siddharthkp requested review from a team as code owners October 17, 2025 07:50
@siddharthkp siddharthkp changed the title chore: remove styled-system from BaseStyles chore: remove styled-system and useTheme from BaseStyles Oct 17, 2025
@siddharthkp siddharthkp merged commit 60ffc7e into bye-bye-styled-components Oct 17, 2025
42 of 43 checks passed
@siddharthkp siddharthkp deleted the chore/remove-styled-system-from-basestyles branch October 17, 2025 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh skip changeset This change does not need a changelog staff Author is a staff member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants