Skip to content

Conversation

mperrotti
Copy link
Contributor

Closes https://github.com/github/primer/issues/5273

Before After
Screenshot 2025-10-14 at 3 08 24 PM Screenshot 2025-10-14 at 3 07 49 PM

Changelog

New

Changed

  • Background of indeterminate checkbox is now "greyed out" when disabled

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@mperrotti mperrotti requested a review from a team as a code owner October 14, 2025 19:08
Copy link

changeset-bot bot commented Oct 14, 2025

🦋 Changeset detected

Latest commit: ca93370

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@primer/react Patch
@primer/styled-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR corrects the background color of disabled indeterminate checkboxes by reorganizing CSS selector order to ensure proper inheritance. The disabled styling was not being applied to indeterminate checkboxes due to CSS specificity conflicts.

  • Moved general :disabled styles after the :checked selector block
  • Ensures disabled indeterminate checkboxes inherit the "greyed out" appearance consistently

Copy link
Contributor

Uh oh! @mperrotti, at least one image you shared is missing helpful alt text. Check your pull request body to fix the following violations:

  • Images should have meaningful alternative text (alt text) at line 7
  • Images should have meaningful alternative text (alt text) at line 7
  • Images should have meaningful alternative text (alt text) at line 7
  • Images should have meaningful alternative text (alt text) at line 7

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

🤖 Beep boop! This comment was added automatically by github/accessibility-alt-text-bot.

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Oct 14, 2025
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot requested a deployment to storybook-preview-7007 October 14, 2025 19:16 Abandoned
@github-actions github-actions bot requested a deployment to storybook-preview-7007 October 14, 2025 19:22 Abandoned
@github-actions github-actions bot temporarily deployed to storybook-preview-7007 October 14, 2025 19:32 Inactive
Copy link
Member

@francinelucca francinelucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wondering if this is worth sneaking into some VRT story 👀

@mperrotti
Copy link
Contributor Author

wondering if this is worth sneaking into some VRT story 👀

@francinelucca - I think this covers it :)

@mperrotti mperrotti added this pull request to the merge queue Oct 16, 2025
Merged via the queue into main with commit 96968a2 Oct 16, 2025
40 of 41 checks passed
@mperrotti mperrotti deleted the mp/checkbox-papercuts-oct2025 branch October 16, 2025 15:26
@primer primer bot mentioned this pull request Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants