-
Notifications
You must be signed in to change notification settings - Fork 638
Correct bg color of disabled indeterminate checkbox #7007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: ca93370 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR corrects the background color of disabled indeterminate checkboxes by reorganizing CSS selector order to ensure proper inheritance. The disabled styling was not being applied to indeterminate checkboxes due to CSS specificity conflicts.
- Moved general
:disabled
styles after the:checked
selector block - Ensures disabled indeterminate checkboxes inherit the "greyed out" appearance consistently
Uh oh! @mperrotti, at least one image you shared is missing helpful alt text. Check your pull request body to fix the following violations:
Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image. Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wondering if this is worth sneaking into some VRT story 👀
@francinelucca - I think this covers it :) |
Closes https://github.com/github/primer/issues/5273
Changelog
New
Changed
Removed
Rollout strategy
Testing & Reviewing
Merge checklist