Skip to content

Conversation

TylerJDev
Copy link
Member

@TylerJDev TylerJDev commented Oct 14, 2025

Closes https://github.com/github/primer/issues/5901

Adds test for SelectPanel to ensure events don't propagate outside of the component, specifically certain key events.

Changelog

New

  • Adds test to SelectPanel.test.tsx

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@TylerJDev TylerJDev added the skip changeset This change does not need a changelog label Oct 14, 2025
Copy link

changeset-bot bot commented Oct 14, 2025

⚠️ No Changeset found

Latest commit: faad4d8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Oct 14, 2025
@TylerJDev TylerJDev marked this pull request as ready for review October 14, 2025 18:04
@TylerJDev TylerJDev requested a review from a team as a code owner October 14, 2025 18:04
@TylerJDev TylerJDev requested review from Copilot and siddharthkp and removed request for siddharthkp October 14, 2025 18:04
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Oct 14, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a test case to verify that keyboard events within the SelectPanel component don't propagate to parent elements, which is important for preventing unintended interactions when users are navigating through the component's options.

  • Adds event propagation test for SelectPanel component
  • Ensures keyboard events (specifically alphabet keys) are properly contained within the component
  • Tests that events don't bubble up to parent containers when navigating through SelectPanel options

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm skip changeset This change does not need a changelog staff Author is a staff member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants