-
Notifications
You must be signed in to change notification settings - Fork 639
SelectPanel: Add test for event propagation #7006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a test case to verify that keyboard events within the SelectPanel component don't propagate to parent elements, which is important for preventing unintended interactions when users are navigating through the component's options.
- Adds event propagation test for SelectPanel component
- Ensures keyboard events (specifically alphabet keys) are properly contained within the component
- Tests that events don't bubble up to parent containers when navigating through SelectPanel options
Co-authored-by: Copilot <[email protected]>
Closes https://github.com/github/primer/issues/5901
Adds test for SelectPanel to ensure events don't propagate outside of the component, specifically certain key events.
Changelog
New
SelectPanel.test.tsx
Rollout strategy
Testing & Reviewing
Merge checklist