Skip to content

Conversation

@siddharthkp
Copy link
Member

@siddharthkp siddharthkp commented Oct 13, 2025

if we simply delete ThemeProvider and BaseStyles,

things that break:

  • ThemeProviderProps, BaseStylesProps are not exported (need to be exported from styled-react)
  • ConfirmationDialog
  • tests.tsx that have ThemeProvider wrapper
  • stories.tsx that have ThemeProvider wrapper
  • IssueLabelToken, IssueLabel
  • deprecated/ActionList

potential tasks:

  1. export theme props from styled-react (right now we re-export)
  2. stop exporting ThemeProvider (and BaseStyles?) → v38
  3. give components that depend on colorMode the theme from somewhere else (ConfirmationDialog, IssueLabelToken, IssueLabel, BaseStyles)
  4. cleanup stories, tests, deprecated components (like ActionList)
  5. delete ThemeProvider (+ BaseStyles? we might want to keep BaseStyles, also for storybook)

Changelog

New

Changed

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot
Copy link

changeset-bot bot commented Oct 13, 2025

⚠️ No Changeset found

Latest commit: e81d00b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Oct 13, 2025
@github-actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot requested a deployment to storybook-preview-6998 October 13, 2025 21:22 Abandoned
@github-actions github-actions bot requested a deployment to storybook-preview-6998 October 13, 2025 21:26 Abandoned
@github-actions github-actions bot requested a deployment to storybook-preview-6998 October 13, 2025 21:40 Abandoned
@github-actions github-actions bot requested a deployment to storybook-preview-6998 October 13, 2025 21:50 Abandoned
@github-actions github-actions bot requested a deployment to storybook-preview-6998 October 13, 2025 22:13 Abandoned
@siddharthkp siddharthkp added the skip changeset This change does not need a changelog label Oct 13, 2025
@github-actions github-actions bot requested a deployment to storybook-preview-6998 October 13, 2025 22:23 Abandoned
@github-actions github-actions bot requested a deployment to storybook-preview-6998 October 13, 2025 22:29 Abandoned
@github-actions github-actions bot requested a deployment to storybook-preview-6998 October 13, 2025 22:35 Abandoned
@github-actions github-actions bot requested a deployment to storybook-preview-6998 October 13, 2025 22:41 Abandoned
@github-actions github-actions bot requested a deployment to storybook-preview-6998 October 15, 2025 18:23 Abandoned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm skip changeset This change does not need a changelog staff Author is a staff member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants