Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/dull-wolves-judge.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/react': patch
---

Removes unwanted box-shadow on buttons with 'inactive' prop passed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 4 additions & 0 deletions e2e/components/LinkButton.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@ const stories = [
title: 'Invisible',
id: 'components-linkbutton-features--invisible',
},
{
title: 'Link',
id: 'components-linkbutton-features--link',
},
{
title: 'Large',
id: 'components-linkbutton-features--large',
Expand Down
1 change: 1 addition & 0 deletions packages/react/src/Button/ButtonBase.module.css
Original file line number Diff line number Diff line change
Expand Up @@ -510,6 +510,7 @@
background-color: var(--button-inactive-bgColor);
/* stylelint-disable-next-line primer/colors */
border-color: var(--button-inactive-bgColor);
box-shadow: none;

& .Visual,
& .CounterLabel {
Expand Down
6 changes: 6 additions & 0 deletions packages/react/src/Button/LinkButton.features.stories.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,12 @@ export const Invisible = () => (
</LinkButton>
)

export const Link = () => (
<LinkButton href="#" variant="link">
Button that looks like a link
</LinkButton>
)

export const LeadingVisual = () => (
<LinkButton href="#" leadingVisual={HeartIcon}>
Leading visual
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/Button/LinkButton.stories.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ Playground.argTypes = {
control: {
type: 'radio',
},
options: ['default', 'primary', 'danger', 'invisible', 'outline'],
options: ['default', 'primary', 'danger', 'invisible', 'outline', 'link'],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we removing this? 👀

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean adding?

},
alignContent: {
control: {
Expand Down
Loading