Fix: ActionMenu with overflow doesn’t contain scrollbars within its rounded border #6978
Conversation
🦋 Changeset detectedLatest commit: 5769bb8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Uh oh! @pksjce, at least one image you shared is missing helpful alt text. Check your pull request body to fix the following violations:
Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image. Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.
|
github-actions
bot
added
the
integration-tests: recommended
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
github-actions
bot
requested a deployment
to
storybook-preview-6978
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
github-actions
bot
added
integration-tests: failing
|
With the same fix on copilot chat, it looks like this Before Screen.Recording.2025-10-14.at.3.01.30.pm.movAfter Screen.Recording.2025-10-14.at.3.02.03.pm.mov |
|
🔴 ci completed with status |
| ref={containerRef} | ||
| className={styles.ActionMenuContainer} | ||
| data-variant={responsiveVariant} | ||
| {...(overlayProps.overflow ? {[`data-overflow-${overlayProps.overflow}`]: ''} : {})} |
There was a problem hiding this comment.
Do we want a default value or not?
There was a problem hiding this comment.
not sure :( Don't want to add unnecessary hidden. I just want it to reflect its parent.
There was a problem hiding this comment.
Valid, what's the default right now? Maybe we should keep that (is it auto?)
There was a problem hiding this comment.
It came with no value(maybe default is visible from docs). And I add it only if parent has some value.
|
The integration PR seems to have conflicts even though I rebuilt this PR and it is up to date. I'll create one manually. |
|
👋 @pksjce Let me know whenever you'd like a review on this again |
|
👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/4919 |
3 participants
Closes ##4938
Changelog
The fix is to have an element inside the Overlay that has overflow and max-height set to it.
This kind of works here. Not sure if there is a better way.
Rollout strategy
Testing & Reviewing
Merge checklist