Skip to content

chore: update eslint-plugin-storybook to v9 #6219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

joshblack
Copy link
Member

Update storybook's eslint plugin to v9. This should help land: #6198

Changelog

New

Changed

  • Fix new lint errors where we need to import from @storybook/react-vite instead of @storybook/react

Removed

Rollout strategy

  • None; if selected, include a brief description as to why

This is a change to our linting setup

@Copilot Copilot AI review requested due to automatic review settings June 18, 2025 17:13
@joshblack joshblack requested a review from a team as a code owner June 18, 2025 17:13
@joshblack joshblack requested a review from jonrohan June 18, 2025 17:13
Copy link

changeset-bot bot commented Jun 18, 2025

⚠️ No Changeset found

Latest commit: b2b6a38

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@joshblack joshblack added the skip changeset This change does not need a changelog label Jun 18, 2025
@github-actions github-actions bot added the staff Author is a staff member label Jun 18, 2025
@joshblack joshblack enabled auto-merge June 18, 2025 17:13
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates the Storybook ESLint plugin to v9 and fixes reported lint errors by changing TypeScript Storybook imports to the new @storybook/react-vite entrypoint.

  • Bumped eslint-plugin-storybook to ^9.0.12 in package.json
  • Replaced all import type {...} from '@storybook/react' with from '@storybook/react-vite' across story files

Reviewed Changes

Copilot reviewed 202 out of 203 changed files in this pull request and generated 1 comment.

File Description
package.json Bump eslint-plugin-storybook to v9.0.12
packages/react/src/**/*.stories.tsx Change Storybook type imports to @storybook/react-vite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog staff Author is a staff member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant