-
Notifications
You must be signed in to change notification settings - Fork 615
docs: update theming example to next 15 #6209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the theming example from Next.js v14 to v15, ensuring compatibility with the latest Next.js features.
- Added a
target
of ES2017 to the TypeScript config. - Converted
RootLayout
to an async component to await the newcookies()
API. - Bumped
next
,react
,react-dom
, and ESLint plugin versions; loosened the@primer/react
version specifier.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
examples/theming/tsconfig.json | Added "target": "ES2017" under compilerOptions |
examples/theming/src/app/layout.tsx | Marked RootLayout async and awaited cookies() |
examples/theming/package.json | Updated dependencies to Next.js v15 and caret ranges |
@@ -11,16 +11,16 @@ | |||
}, | |||
"dependencies": { | |||
"@primer/octicons-react": "^19.14.0", | |||
"@primer/react": "37.26.0", | |||
"@primer/react": "^37.26.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Consider whether the example should pin @primer/react
to an exact version or keep the caret range to maintain consistency with other example workspaces.
"@primer/react": "^37.26.0", | |
"@primer/react": "37.26.0", |
Copilot uses AI. Check for mistakes.
Update our theming example from Next v14 to v15.
Changelog
New
Changed
examples/theming
from Next v14 to Next v15Removed
Rollout strategy
This change is only to an internal example and does not affect our Public API.