Skip to content

docs: update theming example to next 15 #6209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

joshblack
Copy link
Member

@joshblack joshblack commented Jun 16, 2025

Update our theming example from Next v14 to v15.

Changelog

New

Changed

  • Update examples/theming from Next v14 to Next v15

Removed

Rollout strategy

  • None; if selected, include a brief description as to why

This change is only to an internal example and does not affect our Public API.

Copy link

changeset-bot bot commented Jun 16, 2025

⚠️ No Changeset found

Latest commit: dab8883

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@joshblack joshblack added the skip changeset This change does not need a changelog label Jun 16, 2025
@github-actions github-actions bot added the staff Author is a staff member label Jun 16, 2025
Copy link
Contributor

github-actions bot commented Jun 16, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 92.33 KB (0%)
packages/react/dist/browser.umd.js 92.37 KB (0%)

@joshblack joshblack marked this pull request as ready for review June 16, 2025 16:44
@Copilot Copilot AI review requested due to automatic review settings June 16, 2025 16:44
@joshblack joshblack requested a review from a team as a code owner June 16, 2025 16:44
@joshblack joshblack requested a review from TylerJDev June 16, 2025 16:44
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the theming example from Next.js v14 to v15, ensuring compatibility with the latest Next.js features.

  • Added a target of ES2017 to the TypeScript config.
  • Converted RootLayout to an async component to await the new cookies() API.
  • Bumped next, react, react-dom, and ESLint plugin versions; loosened the @primer/react version specifier.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

File Description
examples/theming/tsconfig.json Added "target": "ES2017" under compilerOptions
examples/theming/src/app/layout.tsx Marked RootLayout async and awaited cookies()
examples/theming/package.json Updated dependencies to Next.js v15 and caret ranges

@@ -11,16 +11,16 @@
},
"dependencies": {
"@primer/octicons-react": "^19.14.0",
"@primer/react": "37.26.0",
"@primer/react": "^37.26.0",
Copy link
Preview

Copilot AI Jun 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider whether the example should pin @primer/react to an exact version or keep the caret range to maintain consistency with other example workspaces.

Suggested change
"@primer/react": "^37.26.0",
"@primer/react": "37.26.0",

Copilot uses AI. Check for mistakes.

@github-actions github-actions bot requested a deployment to storybook-preview-6209 June 17, 2025 17:02 Abandoned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog staff Author is a staff member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants