Skip to content

docs: add style guide docs #5987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 6, 2025
Merged

docs: add style guide docs #5987

merged 7 commits into from
May 6, 2025

Conversation

joshblack
Copy link
Member

Add initial style guide based off of: #5805

Figured this was enough to get started, we can add more over time 👀

Let me know what you all thinks!

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 30, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 56396f5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@joshblack joshblack added the skip changeset This change does not need a changelog label Apr 30, 2025
@github-actions github-actions bot added the staff Author is a staff member label Apr 30, 2025
@joshblack joshblack mentioned this pull request Apr 30, 2025
Closed
@joshblack joshblack marked this pull request as ready for review April 30, 2025 19:26
@Copilot Copilot AI review requested due to automatic review settings April 30, 2025 19:26
@joshblack joshblack requested a review from a team as a code owner April 30, 2025 19:26
@joshblack joshblack requested a review from francinelucca April 30, 2025 19:26
Copilot
Copilot AI reviewed Apr 30, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 30, 2025 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 98.77 KB (0%)
packages/react/dist/browser.umd.js 99.14 KB (0%)

@github-actions github-actions bot requested a deployment to storybook-preview-5987 April 30, 2025 19:29 Abandoned
@github-actions github-actions bot temporarily deployed to storybook-preview-5987 April 30, 2025 19:44 Inactive
francinelucca
francinelucca reviewed May 1, 2025
View reviewed changes
Copy link
Member

@francinelucca francinelucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! some comments/suggestions

joshblack and others added 2 commits May 1, 2025 11:04
@github-actions github-actions bot requested a deployment to storybook-preview-5987 May 1, 2025 16:07 Abandoned
@github-actions github-actions bot temporarily deployed to storybook-preview-5987 May 1, 2025 16:22 Inactive
jonrohan
jonrohan approved these changes May 6, 2025
View reviewed changes
Copy link
Member

@jonrohan jonrohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@joshblack joshblack enabled auto-merge May 6, 2025 18:41
@github-actions github-actions bot temporarily deployed to storybook-preview-5987 May 6, 2025 18:53 Inactive
@joshblack joshblack added this pull request to the merge queue May 6, 2025
Merged via the queue into main with commit 239712c May 6, 2025
45 checks passed
@joshblack joshblack deleted the docs/add-style-docs branch May 6, 2025 19:34
hectahertz pushed a commit that referenced this pull request May 20, 2025
@joshblack @francinelucca @hectahertz
docs: add style guide docs (#5987)
eaf4013 
Co-authored-by: Marie Lucca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francinelucca francinelucca francinelucca left review comments

Copilot code review Copilot Copilot left review comments

@jonrohan jonrohan jonrohan approved these changes

@hectahertz hectahertz Awaiting requested review from hectahertz

@TylerJDev TylerJDev Awaiting requested review from TylerJDev

Assignees
No one assigned
Labels
skip changeset This change does not need a changelog staff Author is a staff member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshblack @jonrohan @francinelucca