Skip to content

[CSS Module Migration] Remove feature flag for Underline Panel #5836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 2, 2025
Merged

[CSS Module Migration] Remove feature flag for Underline Panel #5836

merged 6 commits into from
Apr 2, 2025

Conversation

jamieshark
Copy link
Contributor

@jamieshark jamieshark commented Mar 28, 2025 •
edited
Loading

This PR removes the CSS modules feature flag from the FormControl component. The component UnderlinePanel is used 0 times in dotcom.

Changelog

New

Changed

Removed

Feature flag for Underline Panel and associated components

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 28, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 0bad285

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Mar 28, 2025
@github-actions GitHub Actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 28, 2025 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 105.54 KB (-0.46% 🔽)
packages/react/dist/browser.umd.js 105.82 KB (-0.52% 🔽)

@github-actions github-actions bot temporarily deployed to storybook-preview-5836 March 28, 2025 20:55 Inactive
@github-actions github-actions bot requested a deployment to storybook-preview-5836 April 1, 2025 21:25 Abandoned
@jamieshark jamieshark mentioned this pull request Apr 1, 2025
Merged
13 tasks
@jamieshark jamieshark marked this pull request as ready for review April 1, 2025 21:33
@jamieshark jamieshark requested a review from a team as a code owner April 1, 2025 21:33
@jamieshark jamieshark requested a review from francinelucca April 1, 2025 21:33
@langermank langermank added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Apr 1, 2025
@github-actions github-actions bot temporarily deployed to storybook-preview-5836 April 1, 2025 21:37 Inactive
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Apr 1, 2025
@github-actions github-actions bot temporarily deployed to storybook-preview-5836 April 1, 2025 21:47 Inactive
@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Apr 1, 2025
francinelucca
francinelucca approved these changes Apr 2, 2025
View reviewed changes
Copy link
Member

@francinelucca francinelucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM barring integration failures

@github-actions github-actions bot temporarily deployed to storybook-preview-5836 April 2, 2025 18:08 Inactive
@jamieshark jamieshark added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Apr 2, 2025
@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/370942

@primer primer bot requested a review from a team as a code owner April 2, 2025 19:04
@primer primer bot requested a review from mperrotti April 2, 2025 19:04
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Apr 2, 2025
@primer-integration
Copy link

🟢 golden-jobs completed with status success.

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: failing Changes in this PR cause breaking changes in gh/gh labels Apr 2, 2025
@jamieshark jamieshark added this pull request to the merge queue Apr 2, 2025
Merged via the queue into main with commit c177e5e Apr 2, 2025
44 checks passed
@jamieshark jamieshark deleted the css_modules_remove_flag_underlinepanels branch April 2, 2025 21:06
@primer primer bot mentioned this pull request Apr 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@francinelucca francinelucca francinelucca approved these changes

@mperrotti mperrotti Awaiting requested review from mperrotti mperrotti is a code owner automatically assigned from primer/design-reviewers

Assignees

No one assigned

Labels

integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jamieshark @francinelucca @langermank @Copilot