-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overlay: Fix position for fullscreen overlay on narrow screens #5835
Conversation
🦋 Changeset detectedLatest commit: 382191d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
size-limit report 📦
|
👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/370328 |
🟢 golden-jobs completed with status |
Note
Current status:
main
is failing integration tests, so need to run integration tests again once that is cleared upFull screen overlay should have
position: fixed
(notabsolute
) so that it renders attop: 0
even when the page has scrolled.(would be nice to add a vrt test, but i'm in a rush 😅)
Rollout strategy
Testing & Reviewing
Merge checklist