Overlay: Fix position for fullscreen overlay on narrow screens #5835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 382191d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
staff
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
siddharthkp
changed the title
size-limit report 📦
|
github-actions
bot
added
integration-tests: failing
TylerJDev
approved these changes
Mar 31, 2025
|
👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/370328 |
|
🟢 golden-jobs completed with status |
github-actions
bot
added
integration-tests: passing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Current status:
mainis failing integration tests, so need to run integration tests again once that is cleared upFull screen overlay should have
position: fixed(notabsolute) so that it renders attop: 0even when the page has scrolled.(would be nice to add a vrt test, but i'm in a rush 😅)
Rollout strategy
Testing & Reviewing
Merge checklist