Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overlay: Fix position for fullscreen overlay on narrow screens #5835

Merged
merged 6 commits into from
Mar 31, 2025

Conversation

siddharthkp
Copy link
Member

@siddharthkp siddharthkp commented Mar 28, 2025

Note

Current status: main is failing integration tests, so need to run integration tests again once that is cleared up

Full screen overlay should have position: fixed (not absolute) so that it renders at top: 0 even when the page has scrolled.

(would be nice to add a vrt test, but i'm in a rush 😅)

Rollout strategy

  • Patch release (and feature flagged)
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@siddharthkp siddharthkp self-assigned this Mar 28, 2025
@siddharthkp siddharthkp requested a review from a team as a code owner March 28, 2025 20:02
Copy link

changeset-bot bot commented Mar 28, 2025

🦋 Changeset detected

Latest commit: 382191d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Mar 28, 2025
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@siddharthkp siddharthkp changed the title Overlay: Fix fullscreen overlay position Overlay: Fix position for fullscreen overlay on narrow screens Mar 28, 2025
Copy link
Contributor

github-actions bot commented Mar 28, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 105.91 KB (-0.01% 🔽)
packages/react/dist/browser.umd.js 106.24 KB (+0.05% 🔺)

@github-actions github-actions bot requested a deployment to storybook-preview-5835 March 28, 2025 20:09 Abandoned
@github-actions github-actions bot temporarily deployed to storybook-preview-5835 March 28, 2025 20:24 Inactive
@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Mar 28, 2025
@github-actions github-actions bot requested a deployment to storybook-preview-5835 March 31, 2025 17:01 Abandoned
@github-actions github-actions bot requested a deployment to storybook-preview-5835 March 31, 2025 17:21 Abandoned
@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/370328

@primer-integration
Copy link

🟢 golden-jobs completed with status success.

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: failing Changes in this PR cause breaking changes in gh/gh labels Mar 31, 2025
@francinelucca francinelucca added this pull request to the merge queue Mar 31, 2025
Merged via the queue into main with commit 2cb629a Mar 31, 2025
44 checks passed
@francinelucca francinelucca deleted the overlay-fullscreen-fixed branch March 31, 2025 20:29
@primer primer bot mentioned this pull request Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh staff Author is a staff member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants